From: James Moger <james.moger@gitblit.com>
Date: Wed, 31 Oct 2012 12:50:20 +0000 (-0400)
Subject: Reject add if permission selector has not been set
X-Git-Tag: v1.2.0~118
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=717267cdf6fff130865c194dc33620ac1cd10a51;p=gitblit.git

Reject add if permission selector has not been set
---

diff --git a/src/com/gitblit/wicket/panels/RegistrantPermissionsPanel.java b/src/com/gitblit/wicket/panels/RegistrantPermissionsPanel.java
index 27e48fbe..1d451a67 100644
--- a/src/com/gitblit/wicket/panels/RegistrantPermissionsPanel.java
+++ b/src/com/gitblit/wicket/panels/RegistrantPermissionsPanel.java
@@ -169,6 +169,9 @@ public class RegistrantPermissionsPanel extends BasePanel {
 			protected void onSubmit(AjaxRequestTarget target, Form<?> form) {
 				// add permission to our list
 				RegistrantAccessPermission rp = (RegistrantAccessPermission) form.getModel().getObject();
+				if (rp.permission == null) {
+					return;
+				}
 				RegistrantAccessPermission copy = DeepCopier.copy(rp);
 				if (StringUtils.findInvalidCharacter(copy.registrant) != null) {
 					copy.permissionType = PermissionType.REGEX;