From: Toshi MARUYAMA Date: Tue, 24 Sep 2019 05:20:58 +0000 (+0000) Subject: code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_hel... X-Git-Tag: 4.1.0~567 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7272399dc94308f31147347323bcb406a97edb2b;p=redmine.git code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_helper.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18513 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 9394ab770..d5b58b060 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1424,7 +1424,6 @@ Style/ParenthesesAroundCondition: Exclude: - 'app/controllers/context_menus_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/issues_helper.rb' - 'app/models/project.rb' - 'app/models/query.rb' - 'app/models/repository/subversion.rb' diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 10c179550..0cc779bac 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -24,7 +24,7 @@ module IssuesHelper def issue_list(issues, &block) ancestors = [] issues.each do |issue| - while (ancestors.any? && !issue.is_descendant_of?(ancestors.last)) + while ancestors.any? && !issue.is_descendant_of?(ancestors.last) ancestors.pop end yield issue, ancestors.size @@ -35,7 +35,7 @@ module IssuesHelper def grouped_issue_list(issues, query, &block) ancestors = [] grouped_query_results(issues, query) do |issue, group_name, group_count, group_totals| - while (ancestors.any? && !issue.is_descendant_of?(ancestors.last)) + while ancestors.any? && !issue.is_descendant_of?(ancestors.last) ancestors.pop end yield issue, ancestors.size, group_name, group_count, group_totals