From: Philippe Perrin <philippe.perrin@sonarsource.com>
Date: Thu, 15 Apr 2021 07:06:22 +0000 (+0200)
Subject: SONAR-14684 Fix SSF-151
X-Git-Tag: 8.9.0.43852~103
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=73785a8ae690606b526173971b81a4391738ee9d;p=sonarqube.git

SONAR-14684 Fix SSF-151
---

diff --git a/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java b/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java
index 05a87fb9d0c..d6425d0d73e 100644
--- a/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java
+++ b/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java
@@ -29,6 +29,7 @@ import org.sonar.api.config.PropertyDefinition;
 
 import static java.lang.String.valueOf;
 import static org.sonar.api.PropertyType.BOOLEAN;
+import static org.sonar.api.PropertyType.PASSWORD;
 import static org.sonar.api.PropertyType.STRING;
 
 public class GitHubSettings {
@@ -117,6 +118,7 @@ public class GitHubSettings {
         .description("Client password provided by GitHub when registering the application.")
         .category(CATEGORY)
         .subCategory(SUBCATEGORY)
+        .type(PASSWORD)
         .index(3)
         .build(),
       PropertyDefinition.builder(ALLOW_USERS_TO_SIGN_UP)
diff --git a/server/sonar-auth-gitlab/src/main/java/org/sonar/auth/gitlab/GitLabSettings.java b/server/sonar-auth-gitlab/src/main/java/org/sonar/auth/gitlab/GitLabSettings.java
index ef521cff1ec..9a9cec5cb95 100644
--- a/server/sonar-auth-gitlab/src/main/java/org/sonar/auth/gitlab/GitLabSettings.java
+++ b/server/sonar-auth-gitlab/src/main/java/org/sonar/auth/gitlab/GitLabSettings.java
@@ -28,6 +28,7 @@ import org.sonar.api.config.PropertyDefinition;
 
 import static java.lang.String.valueOf;
 import static org.sonar.api.PropertyType.BOOLEAN;
+import static org.sonar.api.PropertyType.PASSWORD;
 
 public class GitLabSettings {
 
@@ -106,6 +107,7 @@ public class GitLabSettings {
         .description("Secret provided by GitLab when registering the application.")
         .category(CATEGORY)
         .subCategory(SUBCATEGORY)
+        .type(PASSWORD)
         .index(4)
         .build(),
       PropertyDefinition.builder(GITLAB_AUTH_ALLOW_USERS_TO_SIGNUP)
diff --git a/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java b/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java
index 88776a26acc..4cae9f55b38 100644
--- a/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java
+++ b/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java
@@ -28,6 +28,7 @@ import org.sonar.api.server.ServerSide;
 
 import static java.lang.String.valueOf;
 import static org.sonar.api.PropertyType.BOOLEAN;
+import static org.sonar.api.PropertyType.PASSWORD;
 
 @ServerSide
 public class SamlSettings {
@@ -146,6 +147,7 @@ public class SamlSettings {
         .description("X.509 certificate for the identity provider.")
         .category(CATEGORY)
         .subCategory(SUBCATEGORY)
+        .type(PASSWORD)
         .index(6)
         .build(),
       PropertyDefinition.builder(USER_LOGIN_ATTRIBUTE)