From: Julien HENRY <julien.henry@sonarsource.com>
Date: Mon, 19 Feb 2018 10:33:51 +0000 (+0100)
Subject: Log a better message in case of missing branch
X-Git-Tag: 7.5~1647
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=73a157ba6181a3320dabe1caa452e18806cbd9f9;p=sonarqube.git

Log a better message in case of missing branch
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/component/MergeBranchComponentUuids.java b/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/component/MergeBranchComponentUuids.java
index 839e59fe863..5d12477afea 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/component/MergeBranchComponentUuids.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/component/MergeBranchComponentUuids.java
@@ -22,12 +22,15 @@ package org.sonar.server.computation.task.projectanalysis.component;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import javax.annotation.CheckForNull;
 import org.sonar.db.DbClient;
 import org.sonar.db.DbSession;
+import org.sonar.db.component.BranchDto;
 import org.sonar.db.component.ComponentDto;
 import org.sonar.server.computation.task.projectanalysis.analysis.AnalysisMetadataHolder;
 
+import static com.google.common.base.Preconditions.checkState;
 import static org.sonar.db.component.ComponentDto.removeBranchFromKey;
 
 /**
@@ -56,7 +59,9 @@ public class MergeBranchComponentUuids {
           uuidsByKey.put(dto.getKey(), dto.uuid());
         }
 
-        mergeBranchName = dbClient.branchDao().selectByUuid(dbSession, mergeBranchUuid).get().getKey();
+        Optional<BranchDto> opt = dbClient.branchDao().selectByUuid(dbSession, mergeBranchUuid);
+        checkState(opt.isPresent(), "Merge branch '%s' does not exist", mergeBranchUuid);
+        mergeBranchName = opt.get().getKey();
       }
     }
   }