From: Robin Appelman <robin@icewind.nl>
Date: Mon, 4 May 2020 15:42:28 +0000 (+0200)
Subject: get only groupids in default share backend
X-Git-Tag: v19.0.0RC2~37^2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=756fe45493fd3b82284abcedc51528542edc43bf;p=nextcloud-server.git

get only groupids in default share backend

instead of getting the full group object and then only using the id anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
---

diff --git a/lib/private/Share20/DefaultShareProvider.php b/lib/private/Share20/DefaultShareProvider.php
index ff46badee3b..c2de03ea689 100644
--- a/lib/private/Share20/DefaultShareProvider.php
+++ b/lib/private/Share20/DefaultShareProvider.php
@@ -888,7 +888,7 @@ class DefaultShareProvider implements IShareProvider {
 			$cursor->closeCursor();
 		} elseif ($shareType === \OCP\Share::SHARE_TYPE_GROUP) {
 			$user = $this->userManager->get($userId);
-			$allGroups = $this->groupManager->getUserGroups($user);
+			$allGroups = $this->groupManager->getUserGroupIds($user);
 
 			/** @var Share[] $shares2 */
 			$shares2 = [];
@@ -925,12 +925,7 @@ class DefaultShareProvider implements IShareProvider {
 				}
 
 
-				$groups = array_filter($groups, function ($group) {
-					return $group instanceof IGroup;
-				});
-				$groups = array_map(function (IGroup $group) {
-					return $group->getGID();
-				}, $groups);
+				$groups = array_filter($groups);
 
 				$qb->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(\OCP\Share::SHARE_TYPE_GROUP)))
 					->andWhere($qb->expr()->in('share_with', $qb->createNamedParameter(