From: Daniel Calviño Sánchez <danxuliu@gmail.com>
Date: Thu, 1 Sep 2022 10:46:37 +0000 (+0200)
Subject: Wait for the new user form to be visible
X-Git-Tag: v25.0.0beta4~10^2~4
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=76b0947022bbf6ebcf50dbe92a5116ee7e3de2a9;p=nextcloud-server.git

Wait for the new user form to be visible

Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---

diff --git a/tests/acceptance/features/bootstrap/UsersSettingsContext.php b/tests/acceptance/features/bootstrap/UsersSettingsContext.php
index 074a9ff5f1a..4d17b3b5118 100644
--- a/tests/acceptance/features/bootstrap/UsersSettingsContext.php
+++ b/tests/acceptance/features/bootstrap/UsersSettingsContext.php
@@ -293,8 +293,12 @@ class UsersSettingsContext implements Context, ActorAwareInterface {
 	 * @Then I see that the new user form is shown
 	 */
 	public function iSeeThatTheNewUserFormIsShown() {
-		Assert::assertTrue(
-			$this->actor->find(self::newUserForm(), 10)->isVisible());
+		if (!WaitFor::elementToBeEventuallyShown(
+				$this->actor,
+				self::newUserForm(),
+				$timeout = 10 * $this->actor->getFindTimeoutMultiplier())) {
+			Assert::fail("The new user form is not shown yet after $timeout seconds");
+		}
 	}
 
 	/**