From: Dominik Stadler Date: Wed, 24 Feb 2016 22:39:11 +0000 (+0000) Subject: Bug 47245: Comment out check and exception in case row-records are missing for some... X-Git-Tag: REL_3_14_FINAL~16 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=784bdfe20f8fbe56b766d72ccd78c52e30014423;p=poi.git Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java index b6ad9c9be0..eb097c62e5 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java @@ -209,12 +209,14 @@ public final class HSSFSheet implements org.apache.poi.ss.usermodel.Sheet { hrow = getRow(cval.getRow()); lastrow = hrow; if (hrow == null) { + /* we removed this check, see bug 47245 for the discussion around this // Some tools (like Perl module Spreadsheet::WriteExcel - bug 41187) skip the RowRecords // Excel, OpenOffice.org and GoogleDocs are all OK with this, so POI should be too. if (rowRecordsAlreadyPresent) { // if at least one row record is present, all should be present. throw new RuntimeException("Unexpected missing row when some rows already present"); - } + }*/ + // create the row record on the fly now. RowRecord rowRec = new RowRecord(cval.getRow()); sheet.addRow(rowRec); diff --git a/test-data/spreadsheet/47245_test.xls b/test-data/spreadsheet/47245_test.xls new file mode 100644 index 0000000000..2e30bd5ecf Binary files /dev/null and b/test-data/spreadsheet/47245_test.xls differ