From: Javen O'Neal <onealj@apache.org>
Date: Sun, 27 Dec 2015 23:17:33 +0000 (+0000)
Subject: bug 58740: return unmodifiable list/map when exposing internal data structures
X-Git-Tag: REL_3_14_FINAL~169
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7a6683bfa0c81bc4bdde3cd02e6f6210f981108c;p=poi.git

bug 58740: return unmodifiable list/map when exposing internal data structures
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java b/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java
index d413b64c51..3c40725ad6 100644
--- a/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java
+++ b/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java
@@ -24,6 +24,7 @@ import java.io.InputStream;
 import java.io.OutputStream;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -301,19 +302,19 @@ public class StylesTable extends POIXMLDocumentPart {
     }
 
     public List<XSSFCellBorder> getBorders(){
-        return borders;
+        return Collections.unmodifiableList(borders);
     }
 
     public List<XSSFCellFill> getFills(){
-        return fills;
+        return Collections.unmodifiableList(fills);
     }
 
     public List<XSSFFont> getFonts(){
-        return fonts;
+        return Collections.unmodifiableList(fonts);
     }
 
     public Map<Integer, String> getNumberFormats(){
-        return numberFormats;
+        return Collections.unmodifiableMap(numberFormats);
     }
 
     public int putFill(XSSFCellFill fill) {