From: Linn Mattsson <linma@cendio.se>
Date: Tue, 27 Aug 2024 08:39:10 +0000 (+0200)
Subject: Add FIXME comment regarding macOS minimise fix
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7a70cedfc1a76ccf99d98a108e5710cb8b99fec3;p=tigervnc.git

Add FIXME comment regarding macOS minimise fix

An issue with minimise not working when in fullscreen on macOS was
workaround in Pull Request #1813. The underlaying issue is currently
unknown.

macOS native fullscreen mode was looked into, but no clear answer was
given. See #1813 for details.
---

diff --git a/vncviewer/Viewport.cxx b/vncviewer/Viewport.cxx
index ed5f9899..ad7a6e8d 100644
--- a/vncviewer/Viewport.cxx
+++ b/vncviewer/Viewport.cxx
@@ -1316,6 +1316,8 @@ void Viewport::popupContextMenu()
     break;
   case ID_MINIMIZE:
 #ifdef __APPLE__
+    // FIXME: Workaround for not being able to minimize in fullscreen
+    // https://github.com/TigerVNC/tigervnc/pull/1813
     if (window()->fullscreen_active())
       window()->fullscreen_off();
 #endif