From: Yegor Kozlov Date: Fri, 26 Oct 2012 15:40:53 +0000 (+0000) Subject: Bug #53707: SlideShow.addPicture declares IOException but throws HSLFException X-Git-Tag: 3.10-beta1~111 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7c0f42451140353a24ee6df2b98755de20899158;p=poi.git Bug #53707: SlideShow.addPicture declares IOException but throws HSLFException git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1402550 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/scratchpad/src/org/apache/poi/hslf/usermodel/SlideShow.java b/src/scratchpad/src/org/apache/poi/hslf/usermodel/SlideShow.java index 4561f8e4d3..ca7d839ebb 100644 --- a/src/scratchpad/src/org/apache/poi/hslf/usermodel/SlideShow.java +++ b/src/scratchpad/src/org/apache/poi/hslf/usermodel/SlideShow.java @@ -853,13 +853,13 @@ public final class SlideShow { public int addPicture(File pict, int format) throws IOException { int length = (int) pict.length(); byte[] data = new byte[length]; - try { - FileInputStream is = new FileInputStream(pict); + FileInputStream is = null; + try { + is = new FileInputStream(pict); is.read(data); - is.close(); - } catch (IOException e) { - throw new HSLFException(e); - } + } finally { + if(is != null) is.close(); + } return addPicture(data, format); }