From: Scott González Date: Thu, 25 Oct 2012 09:41:14 +0000 (-0400) Subject: Tabs: Removed select method. Fixes #7156 - Tabs: Remove select method. X-Git-Tag: 1.10.0-beta.1~259 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7cf2719d0c406c7ff17c7e784c0e1e6eb23b562a;p=jquery-ui.git Tabs: Removed select method. Fixes #7156 - Tabs: Remove select method. --- diff --git a/tests/unit/tabs/tabs_deprecated.js b/tests/unit/tabs/tabs_deprecated.js index 6e84accdf..b551b3279 100644 --- a/tests/unit/tabs/tabs_deprecated.js +++ b/tests/unit/tabs/tabs_deprecated.js @@ -391,51 +391,6 @@ test( "remove", function() { equal( element.tabs( "option", "active" ), false ); }); -test( "select", function() { - expect( 23 ); - - var element = $( "#tabs1" ).tabs(); - state( element, 1, 0, 0 ); - element.tabs( "select", 1 ); - state( element, 0, 1, 0 ); - equal( element.tabs( "option", "active" ), 1, "active" ); - equal( element.tabs( "option", "selected" ), 1, "selected" ); - element.tabs( "destroy" ); - - element.tabs({ collapsible: true }); - state( element, 1, 0, 0 ); - element.tabs( "select", 0 ); - state( element, 0, 0, 0 ); - equal( element.tabs( "option", "active" ), false, "active" ); - equal( element.tabs( "option", "selected" ), -1, "selected" ); - element.tabs( "destroy" ); - - element.tabs({ collapsible: true }); - element.tabs( "select", -1 ); - state( element, 0, 0, 0 ); - equal( element.tabs( "option", "active" ), false, "active" ); - equal( element.tabs( "option", "selected" ), -1, "selected" ); - element.tabs( "destroy" ); - - element.tabs(); - state( element, 1, 0, 0 ); - equal( element.tabs( "option", "active" ), 0, "active" ); - equal( element.tabs( "option", "selected" ), 0, "selected" ); - element.tabs( "select", 0 ); - state( element, 1, 0, 0 ); - equal( element.tabs( "option", "active" ), 0, "active" ); - equal( element.tabs( "option", "selected" ), 0, "selected" ); - element.tabs( "select", -1 ); - state( element, 1, 0, 0 ); - equal( element.tabs( "option", "active" ), 0, "active" ); - equal( element.tabs( "option", "selected" ), 0, "selected" ); - - element.tabs( "select", "#fragment-2" ); - state( element, 0, 1, 0 ); - equal( element.tabs( "option", "active" ), 1, "active" ); - equal( element.tabs( "option", "selected" ), 1, "selected" ); -}); - asyncTest( "abort", function() { expect( 1 ); diff --git a/ui/jquery.ui.tabs.js b/ui/jquery.ui.tabs.js index ed0ca1036..10cdaecd4 100644 --- a/ui/jquery.ui.tabs.js +++ b/ui/jquery.ui.tabs.js @@ -1082,21 +1082,6 @@ if ( $.uiBackCompat !== false ) { } }); - // select method - $.widget( "ui.tabs", $.ui.tabs, { - select: function( index ) { - index = this._getIndex( index ); - if ( index === -1 ) { - if ( this.options.collapsible && this.options.selected !== -1 ) { - index = this.options.selected; - } else { - return; - } - } - this.anchors.eq( index ).trigger( this.options.event + this.eventNamespace ); - } - }); - // load event $.widget( "ui.tabs", $.ui.tabs, { _trigger: function( type, event, data ) {