From: Thomas Müller <thomas.mueller@tmit.eu>
Date: Thu, 14 Jan 2016 16:26:30 +0000 (+0100)
Subject: - isolate include calls in installer.php which prevents local variables to be overwritten
X-Git-Tag: v9.0beta1~272^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7d2a6d4c1acd60605c728d57d71a7143989a70aa;p=nextcloud-server.git

- isolate include calls in installer.php which prevents local variables to be overwritten
- add the app to the autoloader before calling install.php
---

diff --git a/lib/private/installer.php b/lib/private/installer.php
index ef5efb09b46..ace3d65c002 100644
--- a/lib/private/installer.php
+++ b/lib/private/installer.php
@@ -128,8 +128,8 @@ class OC_Installer{
 		}
 
 		//run appinfo/install.php
-		if((!isset($data['noinstall']) or $data['noinstall']==false) and file_exists($basedir.'/appinfo/install.php')) {
-			include $basedir.'/appinfo/install.php';
+		if((!isset($data['noinstall']) or $data['noinstall']==false)) {
+			self::includeAppScript($basedir . '/appinfo/install.php');
 		}
 
 		//set the installed version
@@ -560,15 +560,16 @@ class OC_Installer{
 	 */
 	public static function installShippedApp($app) {
 		//install the database
-		if(is_file(OC_App::getAppPath($app)."/appinfo/database.xml")) {
-			OC_DB::createDbFromStructure(OC_App::getAppPath($app)."/appinfo/database.xml");
+		$appPath = OC_App::getAppPath($app);
+		if(is_file("$appPath/appinfo/database.xml")) {
+			OC_DB::createDbFromStructure("$appPath/appinfo/database.xml");
 		}
 
 		//run appinfo/install.php
-		if(is_file(OC_App::getAppPath($app)."/appinfo/install.php")) {
-			include OC_App::getAppPath($app)."/appinfo/install.php";
-		}
-		$info=OC_App::getAppInfo($app);
+		\OC::$loader->addValidRoot($appPath);
+		self::includeAppScript("$appPath/appinfo/install.php");
+
+		$info = OC_App::getAppInfo($app);
 		if (is_null($info)) {
 			return false;
 		}
@@ -609,4 +610,13 @@ class OC_Installer{
 
 		return empty($errors);
 	}
+
+	/**
+	 * @param $basedir
+	 */
+	private static function includeAppScript($script) {
+		if ( file_exists($script) ){
+			include $script;
+		}
+	}
 }