From: Duarte Meneses <duarte.meneses@sonarsource.com>
Date: Wed, 18 Apr 2018 07:30:32 +0000 (+0200)
Subject: SONAR-10577 Fix quality issues
X-Git-Tag: 7.5~1312
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7dd669b81713f335758d9a0673c45a4cf28f9d1f;p=sonarqube.git

SONAR-10577 Fix quality issues
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
index ba1e8c683e3..1b1de06f7d2 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
@@ -164,8 +164,8 @@ public class SearchAction implements IssuesWsAction {
         new Change("5.5", "response fields 'reporter' and 'actionPlan' are removed (drop of action plan and manual issue features)"),
         new Change("5.5", "parameters 'reporters', 'actionPlans' and 'planned' are dropped and therefore ignored (drop of action plan and manual issue features)"),
         new Change("5.5", "response field 'debt' is renamed 'effort'"),
-        new Change("7.2", "response 'issue' now indicates if issue has been created by an externally defined rule engine and his name through the optional 'externalRuleEngine' field")
-      ).setResponseExample(getClass().getResource("search-example.json"));
+        new Change("7.2", "response field 'externalRuleEngine' added to issues that have been imported from an external rule engine"))
+      .setResponseExample(getClass().getResource("search-example.json"));
 
     action.addPagingParams(100, MAX_LIMIT);
     action.createParam(Param.FACETS)
diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
index fdfcd8ef618..6c4d5b36487 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchResponseFormat.java
@@ -200,7 +200,7 @@ public class SearchResponseFormat {
     setNullable(dto.getIssueCloseDate(), issueBuilder::setCloseDate, DateUtils::formatDateTime);
   }
 
-  private String engineNameFrom(RuleKey ruleKey) {
+  private static String engineNameFrom(RuleKey ruleKey) {
     checkState(ruleKey.repository().startsWith(EXTERNAL_RULE_REPO_PREFIX));
     return ruleKey.repository().replace(EXTERNAL_RULE_REPO_PREFIX, "");
   }