From: Decebal Suiu Date: Mon, 14 Apr 2014 14:44:15 +0000 (+0300) Subject: update slf4j to 1.7.5 X-Git-Tag: release-0.8.0~1 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7df691ccec5303aa3740919344e7c7cf556d7691;p=pf4j.git update slf4j to 1.7.5 --- diff --git a/demo/app/pom.xml b/demo/app/pom.xml index 818be11..834eca0 100644 --- a/demo/app/pom.xml +++ b/demo/app/pom.xml @@ -1,6 +1,6 @@ - + ro.fortsoft.pf4j.demo pf4j-demo-parent @@ -15,11 +15,11 @@ ro.fortsoft.pf4j.demo.Boot - 1.6.4 + 1.7.5 - + - + maven-assembly-plugin 2.3 @@ -41,7 +41,7 @@ - + org.apache.maven.plugins maven-jar-plugin @@ -56,7 +56,7 @@ - + maven-deploy-plugin @@ -71,13 +71,13 @@ ro.fortsoft.pf4j pf4j ${project.version} - + ro.fortsoft.pf4j.demo pf4j-demo-api ${project.version} - + @@ -88,21 +88,15 @@ org.slf4j - jul-to-slf4j + slf4j-log4j12 ${slf4j.version} - - org.slf4j - slf4j-log4j12 - ${slf4j.version} - - commons-lang commons-lang 2.4 - + diff --git a/pf4j/pom.xml b/pf4j/pom.xml index 862ba4b..00e6cc6 100644 --- a/pf4j/pom.xml +++ b/pf4j/pom.xml @@ -1,6 +1,6 @@ - + ro.fortsoft.pf4j pf4j-parent @@ -25,19 +25,19 @@ - + org.slf4j slf4j-api - 1.6.4 + 1.7.5 + + + junit + junit + 4.8.1 + test - - junit - junit - 4.8.1 - test - diff --git a/pf4j/src/main/java/ro/fortsoft/pf4j/DefaultPluginManager.java b/pf4j/src/main/java/ro/fortsoft/pf4j/DefaultPluginManager.java index c4ffedf..22f899d 100644 --- a/pf4j/src/main/java/ro/fortsoft/pf4j/DefaultPluginManager.java +++ b/pf4j/src/main/java/ro/fortsoft/pf4j/DefaultPluginManager.java @@ -432,7 +432,6 @@ public class DefaultPluginManager implements PluginManager { throw new IllegalArgumentException(String.format("Unknown pluginId %s", pluginId)); } - PluginWrapper pluginWrapper = getPlugin(pluginId); PluginDescriptor pluginDescriptor = pluginWrapper.getDescriptor(); PluginState pluginState = pluginWrapper.getPluginState(); @@ -470,8 +469,7 @@ public class DefaultPluginManager implements PluginManager { PluginWrapper pluginWrapper = getPlugin(pluginId); if (!isPluginValid(pluginWrapper)) { - log.warn("Plugin '{}:{}' can not be enabled", - pluginWrapper.getPluginId(), + log.warn("Plugin '{}:{}' can not be enabled", pluginWrapper.getPluginId(), pluginWrapper.getDescriptor().getVersion()); return false; } @@ -663,10 +661,11 @@ public class DefaultPluginManager implements PluginManager { return true; } - log.warn(String.format("Plugin '%s:%s' requires a minimum system version of %s", + log.warn("Plugin '{}:{}' requires a minimum system version of {}", pluginWrapper.getPluginId(), pluginWrapper.getDescriptor().getVersion(), - requires)); + requires); + return false; }