From: Go MAEDA <maeda@farend.jp>
Date: Wed, 7 Apr 2021 05:09:13 +0000 (+0000)
Subject: Roadmap tab is missing if there are only inherited from parent project versions ... 
X-Git-Tag: 5.0.0~439
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7fe7fdd7bc87a0e34225e66c91ab6583d6989f28;p=redmine.git

Roadmap tab is missing if there are only inherited from parent project versions (#34983).

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20921 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/lib/redmine.rb b/lib/redmine.rb
index ee9aece1a..465e7dded 100644
--- a/lib/redmine.rb
+++ b/lib/redmine.rb
@@ -367,10 +367,10 @@ Redmine::MenuManager.map :project_menu do |menu|
     :param => :project_id,
     :if =>
       Proc.new do |p|
-        if Setting.display_subprojects_issues?
-          p.rolled_up_versions.any?
+        if p.shared_versions.any?
+          true
         else
-          p.shared_versions.any?
+          Setting.display_subprojects_issues? && p.rolled_up_versions.any?
         end
       end
   )
diff --git a/test/integration/lib/redmine/menu_manager_test.rb b/test/integration/lib/redmine/menu_manager_test.rb
index 5b27bdbf1..9bac57ad4 100644
--- a/test/integration/lib/redmine/menu_manager_test.rb
+++ b/test/integration/lib/redmine/menu_manager_test.rb
@@ -147,4 +147,21 @@ class MenuManagerTest < Redmine::IntegrationTest
       assert_select '#main-menu a.roadmap', 0
     end
   end
+
+  def test_project_menu_should_show_roadmap_if_project_has_shared_version
+    Version.delete_all
+    project = Project.generate!(:parent_id => 2)
+
+    Version.generate!(project_id: 2, sharing: 'tree')
+
+    with_settings :display_subprojects_issues => '1' do
+      get "/projects/#{project.id}"
+      assert_select '#main-menu a.roadmap'
+    end
+
+    with_settings :display_subprojects_issues => '0' do
+      get "/projects/#{project.id}"
+      assert_select '#main-menu a.roadmap'
+    end
+  end
 end