From: Daniel Calviño Sánchez <danxuliu@gmail.com>
Date: Sun, 17 Jan 2021 16:39:35 +0000 (+0100)
Subject: Add missing waits when finding elements in the acceptance tests
X-Git-Tag: v20.0.9RC1~65^2~8
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8077dbf0977e5b07730a71df83982f6a0e1ee8b6;p=nextcloud-server.git

Add missing waits when finding elements in the acceptance tests

As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---

diff --git a/tests/acceptance/features/bootstrap/AppSettingsContext.php b/tests/acceptance/features/bootstrap/AppSettingsContext.php
index b2b6744a36b..d7ee4a2eb00 100644
--- a/tests/acceptance/features/bootstrap/AppSettingsContext.php
+++ b/tests/acceptance/features/bootstrap/AppSettingsContext.php
@@ -74,7 +74,7 @@ class AppSettingsContext implements Context, ActorAwareInterface {
 	 * @Given I open the settings
 	 */
 	public function iOpenTheSettings() {
-		$this->actor->find(self::appSettingsOpenButton())->click();
+		$this->actor->find(self::appSettingsOpenButton(), 10)->click();
 	}
 
 	/**
@@ -84,11 +84,11 @@ class AppSettingsContext implements Context, ActorAwareInterface {
 		$locator = self::CheckboxInTheSettings($id);
 
 		// If locator is not visible, fallback to label
-		if (!$this->actor->find(self::CheckboxInTheSettings($id))->isVisible()) {
+		if (!$this->actor->find(self::CheckboxInTheSettings($id), 10)->isVisible()) {
 			$locator = self::checkboxLabelInTheSettings($id);
 		}
 
-		$this->actor->find($locator)->click();
+		$this->actor->find($locator, 10)->click();
 	}
 
 	/**
diff --git a/tests/acceptance/features/bootstrap/AppsManagementContext.php b/tests/acceptance/features/bootstrap/AppsManagementContext.php
index 1f3b2dbe28a..d86b972c85b 100644
--- a/tests/acceptance/features/bootstrap/AppsManagementContext.php
+++ b/tests/acceptance/features/bootstrap/AppsManagementContext.php
@@ -209,7 +209,7 @@ class AppsManagementContext implements Context, ActorAwareInterface {
 	 * @Given /^I see that the "([^"]*)" is disabled$/
 	 */
 	public function iSeeThatTheIsDisabled($bundle) {
-		PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle))->getValue());
+		PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle), 2)->getValue());
 	}
 
 	/**
diff --git a/tests/acceptance/features/bootstrap/UsersSettingsContext.php b/tests/acceptance/features/bootstrap/UsersSettingsContext.php
index 020da466128..cc542bf2fc4 100644
--- a/tests/acceptance/features/bootstrap/UsersSettingsContext.php
+++ b/tests/acceptance/features/bootstrap/UsersSettingsContext.php
@@ -176,21 +176,21 @@ class UsersSettingsContext implements Context, ActorAwareInterface {
 	 * @When I click the New user button
 	 */
 	public function iClickTheNewUserButton() {
-		$this->actor->find(self::newUserButton())->click();
+		$this->actor->find(self::newUserButton(), 10)->click();
 	}
 
 	/**
 	 * @When I click the :action action in the :user actions menu
 	 */
 	public function iClickTheAction($action, $user) {
-		$this->actor->find(self::theAction($action, $user))->click();
+		$this->actor->find(self::theAction($action, $user), 10)->click();
 	}
 
 	/**
 	 * @When I open the actions menu for the user :user
 	 */
 	public function iOpenTheActionsMenuOf($user) {
-		$this->actor->find(self::actionsMenuOf($user))->click();
+		$this->actor->find(self::actionsMenuOf($user), 10)->click();
 	}
 
 	/**