From: Vsevolod Stakhov Date: Mon, 14 Aug 2023 13:01:09 +0000 (+0100) Subject: [Rework] Finish utils rework X-Git-Tag: 3.7.1~76^2~17 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=81d9b6e8f4eeaa5498e6c4ab7e80eb2789b46aad;p=rspamd.git [Rework] Finish utils rework --- diff --git a/src/controller.c b/src/controller.c index a6d8a7ca9..6f0611ec2 100644 --- a/src/controller.c +++ b/src/controller.c @@ -1,11 +1,11 @@ -/*- - * Copyright 2016 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -2086,7 +2086,6 @@ rspamd_controller_handle_learn_common( task); task->fin_arg = conn_ent; task->http_conn = rspamd_http_connection_ref(conn_ent->conn); - ; task->sock = -1; session->task = task; diff --git a/src/libserver/cfg_file.h b/src/libserver/cfg_file.h index b4b60a92f..18388e642 100644 --- a/src/libserver/cfg_file.h +++ b/src/libserver/cfg_file.h @@ -49,16 +49,6 @@ struct rspamd_external_libs_ctx; struct rspamd_cryptobox_pubkey; struct rspamd_dns_resolver; -/** - * Types of rspamd bind lines - */ -enum rspamd_cred_type { - CRED_NORMAL, - CRED_CONTROL, - CRED_LMTP, - CRED_DELIVERY -}; - /** * Logging type */ @@ -94,17 +84,6 @@ struct script_module { gchar *digest; }; -/** - * Type of lua variable - */ -enum lua_var_type { - LUA_VAR_NUM, - LUA_VAR_BOOLEAN, - LUA_VAR_STRING, - LUA_VAR_FUNCTION, - LUA_VAR_UNKNOWN -}; - enum rspamd_symbol_group_flags { RSPAMD_SYMBOL_GROUP_NORMAL = 0u, RSPAMD_SYMBOL_GROUP_DISABLED = (1u << 0u), @@ -356,12 +335,12 @@ struct rspamd_config { #ifdef WITH_GPERF_TOOLS gchar *profile_path; #endif - gdouble unknown_weight; /**< weight of unknown symbols */ - gdouble grow_factor; /**< grow factor for metric */ - GHashTable *symbols; /**< weights of symbols in metric */ - const gchar *subject; /**< subject rewrite string */ - GHashTable *groups; /**< groups of symbols */ - struct rspamd_action *actions; /**< all actions of the metric */ + gdouble unknown_weight; /**< weight of unknown symbols */ + gdouble grow_factor; /**< grow factor for metric */ + GHashTable *symbols; /**< weights of symbols in metric */ + const gchar *subject; /**< subject rewrite string */ + GHashTable *groups; /**< groups of symbols */ + void *actions; /**< all actions of the metric (opaque type) */ gboolean one_shot_mode; /**< rules add only one symbol */ gboolean check_text_attachements; /**< check text attachements as text */ @@ -730,7 +709,7 @@ gboolean rspamd_config_is_enabled_from_ucl(rspamd_mempool_t *pool, /* * Get action from a string */ -gboolean rspamd_action_from_str(const gchar *data, gint *result); +gboolean rspamd_action_from_str(const gchar *data, enum rspamd_action_type *result); /* * Return textual representation of action enumeration @@ -739,11 +718,6 @@ const gchar *rspamd_action_to_str(enum rspamd_action_type action); const gchar *rspamd_action_to_str_alt(enum rspamd_action_type action); -/* - * Resort all actions (needed to operate with thresholds) - */ -void rspamd_actions_sort(struct rspamd_config *cfg); - /** * Parse radix tree or radix map from ucl object * @param cfg configuration object diff --git a/src/libserver/cfg_file_private.h b/src/libserver/cfg_file_private.h index 1a1500d09..8c9fc6539 100644 --- a/src/libserver/cfg_file_private.h +++ b/src/libserver/cfg_file_private.h @@ -18,9 +18,6 @@ #define RSPAMD_CFG_FILE_PRIVATE_H #include "cfg_file.h" -#include "../../contrib/mumhash/mum.h" -#define HASH_CASELESS -#include "uthash_strcase.h" #ifdef __cplusplus extern "C" { @@ -33,10 +30,8 @@ struct rspamd_action { enum rspamd_action_type action_type; int flags; /* enum rspamd_action_flags */ guint priority; - gint lua_handler_ref; /* If special handling is needed */ gdouble threshold; gchar *name; - struct UT_hash_handle hh; /* Index by name */ }; #ifdef __cplusplus diff --git a/src/libserver/cfg_utils.cxx b/src/libserver/cfg_utils.cxx index d39998080..c4ccf9875 100644 --- a/src/libserver/cfg_utils.cxx +++ b/src/libserver/cfg_utils.cxx @@ -63,10 +63,12 @@ #include #include +#include #include "fmt/core.h" #include "cxx/util.hxx" #include "frozen/unordered_map.h" #include "frozen/string.h" +#include "contrib/ankerl/unordered_dense.h" #define DEFAULT_SCORE 10.0 @@ -111,6 +113,58 @@ RSPAMD_CONSTRUCTOR(rspamd_config_log_init) rspamd_config_log_id = rspamd_logger_add_debug_module("config"); } +struct rspamd_actions_list { + using action_ptr = std::shared_ptr; + std::vector actions; + ankerl::unordered_dense::map actions_by_name; + + explicit rspamd_actions_list() + { + actions.reserve(METRIC_ACTION_MAX + 2); + actions_by_name.reserve(METRIC_ACTION_MAX + 2); + } + + void add_action(action_ptr action) + { + actions.push_back(action); + actions_by_name[action->name] = action; + sort(); + } + + void sort() + { + std::sort(actions.begin(), actions.end(), [](const action_ptr &a1, const action_ptr &a2) -> bool { + if (!isnan(a1->threshold) && !isnan(a2->threshold)) { + if (a1->threshold < a2->threshold) { + return false; + } + else if (a1->threshold > a2->threshold) { + return true; + } + + return false; + } + + if (isnan(a1->threshold) && isnan(a2->threshold)) { + return false; + } + else if (isnan(a1->threshold)) { + return true; + } + + return false; + }); + } + + void clear() + { + actions.clear(); + actions_by_name.clear(); + } +}; + +#define RSPAMD_CFG_ACTIONS(cfg) (reinterpret_cast((cfg)->actions)) + gboolean rspamd_parse_bind_line(struct rspamd_config *cfg, struct rspamd_worker_conf *cf, @@ -181,11 +235,12 @@ rspamd_config_new(enum rspamd_config_init_flags flags) cfg->dns_io_per_server = 16; cfg->unknown_weight = NAN; + cfg->actions = (void *) new rspamd_actions_list(); + /* Add all internal actions to keep compatibility */ for (int i = METRIC_ACTION_REJECT; i < METRIC_ACTION_MAX; i++) { - struct rspamd_action *action; - action = rspamd_mempool_alloc0_type(cfg->cfg_pool, struct rspamd_action); + auto &&action = std::make_shared(); action->threshold = NAN; action->name = rspamd_mempool_strdup(cfg->cfg_pool, rspamd_action_to_str(static_cast(i))); @@ -201,8 +256,7 @@ rspamd_config_new(enum rspamd_config_init_flags flags) action->flags |= RSPAMD_ACTION_HAM; } - HASH_ADD_KEYPTR(hh, cfg->actions, - action->name, strlen(action->name), action); + RSPAMD_CFG_ACTIONS(cfg)->add_action(std::move(action)); } /* Disable timeout */ @@ -366,7 +420,7 @@ void rspamd_config_free(struct rspamd_config *cfg) } rspamd_upstreams_library_unref(cfg->ups_ctx); - HASH_CLEAR(hh, cfg->actions); + delete RSPAMD_CFG_ACTIONS(cfg); rspamd_mempool_destructors_enforce(cfg->cfg_pool); @@ -1049,8 +1103,8 @@ rspamd_include_map_handler(const guchar *data, gsize len, { auto *cfg = (struct rspamd_config *) ud; - auto *map_line = rspamd_mempool_ftokdup(cfg->cfg_pool, - (rspamd_ftok_t{.len = len + 1, .begin = (char *) data})); + auto ftok = rspamd_ftok_t{.len = len + 1, .begin = (char *) data}; + auto *map_line = rspamd_mempool_ftokdup(cfg->cfg_pool, &ftok); auto *cbdata = new rspamd_ucl_map_cbdata{cfg}; auto **pcbdata = new rspamd_ucl_map_cbdata *(cbdata); @@ -1097,8 +1151,6 @@ void rspamd_ucl_add_conf_variables(struct ucl_parser *parser, GHashTable *vars) { GHashTableIter it; gpointer k, v; - gchar *hostbuf; - gsize hostlen; ucl_parser_register_variable(parser, RSPAMD_CONFDIR_MACRO, @@ -1133,7 +1185,7 @@ void rspamd_ucl_add_conf_variables(struct ucl_parser *parser, GHashTable *vars) ucl_parser_register_variable(parser, RSPAMD_BRANCH_VERSION_MACRO, RSPAMD_VERSION_BRANCH); - hostlen = sysconf(_SC_HOST_NAME_MAX); + auto hostlen = sysconf(_SC_HOST_NAME_MAX); if (hostlen <= 0) { hostlen = 256; @@ -1142,19 +1194,22 @@ void rspamd_ucl_add_conf_variables(struct ucl_parser *parser, GHashTable *vars) hostlen++; } - hostbuf = g_alloca(hostlen); - memset(hostbuf, 0, hostlen); - gethostname(hostbuf, hostlen - 1); + auto hostbuf = std::string{}; + hostbuf.resize(hostlen); + + if (gethostname(hostbuf.data(), hostlen) != 0) { + hostbuf = "unknown"; + } /* UCL copies variables, so it is safe to pass an ephemeral buffer here */ ucl_parser_register_variable(parser, RSPAMD_HOSTNAME_MACRO, - hostbuf); + hostbuf.c_str()); if (vars != nullptr) { g_hash_table_iter_init(&it, vars); while (g_hash_table_iter_next(&it, &k, &v)) { - ucl_parser_register_variable(parser, k, v); + ucl_parser_register_variable(parser, (const char *) k, (const char *) v); } } } @@ -1171,10 +1226,10 @@ void rspamd_ucl_add_conf_macros(struct ucl_parser *parser, static void symbols_classifiers_callback(gpointer key, gpointer value, gpointer ud) { - struct rspamd_config *cfg = ud; + auto *cfg = (struct rspamd_config *) ud; /* Actually, statistics should act like any ordinary symbol */ - rspamd_symcache_add_symbol(cfg->cache, key, 0, nullptr, nullptr, + rspamd_symcache_add_symbol(cfg->cache, (const char *) key, 0, nullptr, nullptr, SYMBOL_TYPE_CLASSIFIER | SYMBOL_TYPE_NOSTAT, -1); } @@ -1188,16 +1243,13 @@ void rspamd_config_insert_classify_symbols(struct rspamd_config *cfg) struct rspamd_classifier_config * rspamd_config_find_classifier(struct rspamd_config *cfg, const gchar *name) { - GList *cur; - struct rspamd_classifier_config *cf; - if (name == nullptr) { return nullptr; } - cur = cfg->classifiers; + auto *cur = cfg->classifiers; while (cur) { - cf = cur->data; + auto *cf = (struct rspamd_classifier_config *) cur->data; if (g_ascii_strcasecmp(cf->name, name) == 0) { return cf; @@ -1212,14 +1264,12 @@ rspamd_config_find_classifier(struct rspamd_config *cfg, const gchar *name) gboolean rspamd_config_check_statfiles(struct rspamd_classifier_config *cf) { - struct rspamd_statfile_config *st; gboolean has_other = FALSE, res = FALSE, cur_class = FALSE; - GList *cur; /* First check classes directly */ - cur = cf->statfiles; + auto *cur = cf->statfiles; while (cur) { - st = cur->data; + auto *st = (struct rspamd_statfile_config *) cur->data; if (!has_other) { cur_class = st->is_spam; has_other = TRUE; @@ -1241,7 +1291,7 @@ rspamd_config_check_statfiles(struct rspamd_classifier_config *cf) has_other = FALSE; cur = cf->statfiles; while (cur) { - st = cur->data; + auto *st = (struct rspamd_statfile_config *) cur->data; if (rspamd_substring_search_caseless(st->symbol, strlen(st->symbol), "spam", 4) != -1) { st->is_spam = TRUE; @@ -1890,7 +1940,7 @@ rspamd_config_action_from_ucl(struct rspamd_config *cfg, { const ucl_object_t *elt; gdouble threshold = NAN; - guint flags = 0, std_act, obj_type; + int flags = 0, obj_type; obj_type = ucl_object_type(obj); @@ -1964,6 +2014,8 @@ rspamd_config_action_from_ucl(struct rspamd_config *cfg, act->threshold = threshold; act->flags = flags; + enum rspamd_action_type std_act; + if (!(flags & RSPAMD_ACTION_MILTER)) { if (rspamd_action_from_str(act->name, &std_act)) { act->action_type = std_act; @@ -1981,7 +2033,6 @@ rspamd_config_set_action_score(struct rspamd_config *cfg, const gchar *action_name, const ucl_object_t *obj) { - struct rspamd_action *act; enum rspamd_action_type std_act; const ucl_object_t *elt; guint priority = ucl_object_get_priority(obj), obj_type; @@ -2006,13 +2057,15 @@ rspamd_config_set_action_score(struct rspamd_config *cfg, * variance of names. */ - if (rspamd_action_from_str(action_name, (gint *) &std_act)) { + if (rspamd_action_from_str(action_name, &std_act)) { action_name = rspamd_action_to_str(std_act); } - HASH_FIND_STR(cfg->actions, action_name, act); + auto actions = RSPAMD_CFG_ACTIONS(cfg); + auto existing_act_it = actions->actions_by_name.find(action_name); - if (act) { + if (existing_act_it != actions->actions_by_name.end()) { + auto *act = existing_act_it->second.get(); /* Existing element */ if (act->priority <= priority) { /* We can replace data */ @@ -2024,7 +2077,7 @@ rspamd_config_set_action_score(struct rspamd_config *cfg, priority, act->threshold); if (rspamd_config_action_from_ucl(cfg, act, obj, priority)) { - rspamd_actions_sort(cfg); + actions->sort(); } else { return FALSE; @@ -2040,13 +2093,11 @@ rspamd_config_set_action_score(struct rspamd_config *cfg, } else { /* Add new element */ - act = rspamd_mempool_alloc0(cfg->cfg_pool, sizeof(*act)); + auto act = std::make_shared(); act->name = rspamd_mempool_strdup(cfg->cfg_pool, action_name); - if (rspamd_config_action_from_ucl(cfg, act, obj, priority)) { - HASH_ADD_KEYPTR(hh, cfg->actions, - act->name, strlen(act->name), act); - rspamd_actions_sort(cfg); + if (rspamd_config_action_from_ucl(cfg, act.get(), obj, priority)) { + actions->add_action(std::move(act)); } else { return FALSE; @@ -2061,11 +2112,11 @@ rspamd_config_maybe_disable_action(struct rspamd_config *cfg, const gchar *action_name, guint priority) { - struct rspamd_action *act; - - HASH_FIND_STR(cfg->actions, action_name, act); + auto actions = RSPAMD_CFG_ACTIONS(cfg); + auto maybe_act = rspamd::find_map(actions->actions_by_name, action_name); - if (act) { + if (maybe_act) { + auto *act = maybe_act.value().get().get(); if (priority >= act->priority) { msg_info_config("disable action %s; old priority: %ud, new priority: %ud", action_name, @@ -2093,23 +2144,23 @@ rspamd_config_maybe_disable_action(struct rspamd_config *cfg, struct rspamd_action * rspamd_config_get_action(struct rspamd_config *cfg, const gchar *name) { - struct rspamd_action *res = nullptr; + auto actions = RSPAMD_CFG_ACTIONS(cfg); + auto maybe_act = rspamd::find_map(actions->actions_by_name, name); - HASH_FIND_STR(cfg->actions, name, res); + if (maybe_act) { + return maybe_act.value().get().get(); + } - return res; + return nullptr; } struct rspamd_action * rspamd_config_get_action_by_type(struct rspamd_config *cfg, enum rspamd_action_type type) { - struct rspamd_action *cur, *tmp; - - HASH_ITER(hh, cfg->actions, cur, tmp) - { - if (cur->action_type == type) { - return cur; + for (const auto &act: RSPAMD_CFG_ACTIONS(cfg)->actions) { + if (act->action_type == type) { + return act.get(); } } @@ -2227,49 +2278,35 @@ rspamd_config_radix_from_ucl(struct rspamd_config *cfg, const ucl_object_t *obj, return TRUE; } +constexpr const auto action_types = frozen::make_unordered_map({ + {"reject", METRIC_ACTION_REJECT}, + {"greylist", METRIC_ACTION_GREYLIST}, + {"add header", METRIC_ACTION_ADD_HEADER}, + {"add_header", METRIC_ACTION_ADD_HEADER}, + {"rewrite subject", METRIC_ACTION_REWRITE_SUBJECT}, + {"rewrite_subject", METRIC_ACTION_REWRITE_SUBJECT}, + {"soft reject", METRIC_ACTION_SOFT_REJECT}, + {"soft_reject", METRIC_ACTION_SOFT_REJECT}, + {"no action", METRIC_ACTION_NOACTION}, + {"no_action", METRIC_ACTION_NOACTION}, + {"accept", METRIC_ACTION_NOACTION}, + {"quarantine", METRIC_ACTION_QUARANTINE}, + {"discard", METRIC_ACTION_DISCARD}, + +}); + gboolean -rspamd_action_from_str(const gchar *data, gint *result) +rspamd_action_from_str(const gchar *data, enum rspamd_action_type *result) { - guint64 h; + auto maybe_action = rspamd::find_map(action_types, std::string_view{data}); - h = rspamd_cryptobox_fast_hash_specific(RSPAMD_CRYPTOBOX_XXHASH64, - data, strlen(data), 0xdeadbabe); - - switch (h) { - case 0x9917BFDB46332B8CULL: /* reject */ - *result = METRIC_ACTION_REJECT; - break; - case 0x7130EE37D07B3715ULL: /* greylist */ - *result = METRIC_ACTION_GREYLIST; - break; - case 0xCA6087E05480C60CULL: /* add_header */ - case 0x87A3D27783B16241ULL: /* add header */ - *result = METRIC_ACTION_ADD_HEADER; - break; - case 0x4963374ED8B90449ULL: /* rewrite_subject */ - case 0x5C9FC4679C025948ULL: /* rewrite subject */ - *result = METRIC_ACTION_REWRITE_SUBJECT; - break; - case 0xFC7D6502EE71FDD9ULL: /* soft reject */ - case 0x73576567C262A82DULL: /* soft_reject */ - *result = METRIC_ACTION_SOFT_REJECT; - break; - case 0x207091B927D1EC0DULL: /* no action */ - case 0xB7D92D002CD46325ULL: /* no_action */ - case 0x167C0DF4BAA9BCECULL: /* accept */ - *result = METRIC_ACTION_NOACTION; - break; - case 0x4E9666ECCD3FC314ULL: /* quarantine */ - *result = METRIC_ACTION_QUARANTINE; - break; - case 0x93B346242F7F69B3ULL: /* discard */ - *result = METRIC_ACTION_DISCARD; - break; - default: - return FALSE; + if (maybe_action) { + *result = maybe_action.value().get(); + return true; + } + else { + return false; } - - return TRUE; } const gchar * @@ -2330,36 +2367,6 @@ rspamd_action_to_str_alt(enum rspamd_action_type action) return "unknown action"; } -static int -rspamd_actions_cmp(const struct rspamd_action *a1, const struct rspamd_action *a2) -{ - if (!isnan(a1->threshold) && !isnan(a2->threshold)) { - if (a1->threshold < a2->threshold) { - return -1; - } - else if (a1->threshold > a2->threshold) { - return 1; - } - - return 0; - } - - if (isnan(a1->threshold) && isnan(a2->threshold)) { - return 0; - } - else if (isnan(a1->threshold)) { - return 1; - } - else { - return -1; - } -} - -void rspamd_actions_sort(struct rspamd_config *cfg) -{ - HASH_SORT(cfg->actions, rspamd_actions_cmp); -} - static void rspamd_config_settings_elt_dtor(struct rspamd_config_settings_elt *e) { @@ -2428,7 +2435,7 @@ void rspamd_config_register_settings_id(struct rspamd_config *cfg, DL_DELETE(cfg->setting_ids, elt); - nelt = rspamd_mempool_alloc0(cfg->cfg_pool, sizeof(*nelt)); + nelt = rspamd_mempool_alloc0_type(cfg->cfg_pool, struct rspamd_config_settings_elt); nelt->id = id; nelt->name = rspamd_mempool_strdup(cfg->cfg_pool, name); @@ -2457,7 +2464,7 @@ void rspamd_config_register_settings_id(struct rspamd_config *cfg, REF_RELEASE(elt); } else { - elt = rspamd_mempool_alloc0(cfg->cfg_pool, sizeof(*elt)); + elt = rspamd_mempool_alloc0_type(cfg->cfg_pool, struct rspamd_config_settings_elt); elt->id = id; elt->name = rspamd_mempool_strdup(cfg->cfg_pool, name); @@ -2588,12 +2595,11 @@ struct rspamd_external_libs_ctx * rspamd_init_libs(void) { struct rlimit rlim; - struct rspamd_external_libs_ctx *ctx; struct ottery_config *ottery_cfg; - ctx = g_malloc0(sizeof(*ctx)); + auto *ctx = g_new0(struct rspamd_external_libs_ctx, 1); ctx->crypto_ctx = rspamd_cryptobox_init(); - ottery_cfg = g_malloc0(ottery_get_sizeof_config()); + ottery_cfg = (struct ottery_config *) g_malloc0(ottery_get_sizeof_config()); ottery_config_init(ottery_cfg); ctx->ottery_cfg = ottery_cfg; @@ -2603,10 +2609,12 @@ rspamd_init_libs(void) if ((ctx->crypto_ctx->cpu_config & CPUID_RDRAND) == 0) { ottery_config_disable_entropy_sources(ottery_cfg, OTTERY_ENTROPY_SRC_RDRAND); + } + + g_assert(ottery_init(ottery_cfg) == 0); #if OPENSSL_VERSION_NUMBER >= 0x1000104fL && OPENSSL_VERSION_NUMBER < 0x30000000L && !defined(LIBRESSL_VERSION_NUMBER) - RAND_set_rand_engine(nullptr); + RAND_set_rand_engine(nullptr); #endif - } /* Configure utf8 library */ guint utf8_flags = 0; @@ -2620,8 +2628,6 @@ rspamd_init_libs(void) rspamd_fast_utf8_library_init(utf8_flags); - g_assert(ottery_init(ottery_cfg) == 0); - #ifdef HAVE_LOCALE_H if (getenv("LANG") == nullptr) { setlocale(LC_ALL, "C"); @@ -2658,7 +2664,7 @@ rspamd_open_zstd_dictionary(const char *path) { struct zstd_dictionary *dict; - dict = g_malloc0(sizeof(*dict)); + dict = g_new0(zstd_dictionary, 1); dict->dict = rspamd_file_xmap(path, PROT_READ, &dict->size, TRUE); if (dict->dict == nullptr) { @@ -2688,10 +2694,10 @@ rspamd_free_zstd_dictionary(struct zstd_dictionary *dict) } #ifdef HAVE_OPENBLAS_SET_NUM_THREADS -extern void openblas_set_num_threads(int num_threads); +extern "C" void openblas_set_num_threads(int num_threads); #endif #ifdef HAVE_BLI_THREAD_SET_NUM_THREADS -extern void bli_thread_set_num_threads(int num_threads); +extern "C" void bli_thread_set_num_threads(int num_threads); #endif gboolean @@ -2716,12 +2722,12 @@ rspamd_config_libs(struct rspamd_external_libs_ctx *ctx, rspamd_free_zstd_dictionary(ctx->out_dict); if (ctx->out_zstream) { - ZSTD_freeCStream(ctx->out_zstream); + ZSTD_freeCStream((ZSTD_CCtx *) ctx->out_zstream); ctx->out_zstream = nullptr; } if (ctx->in_zstream) { - ZSTD_freeDStream(ctx->in_zstream); + ZSTD_freeDStream((ZSTD_DCtx *) ctx->in_zstream); ctx->in_zstream = nullptr; } @@ -2785,23 +2791,23 @@ rspamd_config_libs(struct rspamd_external_libs_ctx *ctx, /* Init decompression */ ctx->in_zstream = ZSTD_createDStream(); - r = ZSTD_initDStream(ctx->in_zstream); + r = ZSTD_initDStream((ZSTD_DCtx *) ctx->in_zstream); if (ZSTD_isError(r)) { msg_err("cannot init decompression stream: %s", ZSTD_getErrorName(r)); - ZSTD_freeDStream(ctx->in_zstream); + ZSTD_freeDStream((ZSTD_DCtx *) ctx->in_zstream); ctx->in_zstream = nullptr; } /* Init compression */ ctx->out_zstream = ZSTD_createCStream(); - r = ZSTD_initCStream(ctx->out_zstream, 1); + r = ZSTD_initCStream((ZSTD_CCtx *) ctx->out_zstream, 1); if (ZSTD_isError(r)) { msg_err("cannot init compression stream: %s", ZSTD_getErrorName(r)); - ZSTD_freeCStream(ctx->out_zstream); + ZSTD_freeCStream((ZSTD_CCtx *) ctx->out_zstream); ctx->out_zstream = nullptr; } #ifdef HAVE_OPENBLAS_SET_NUM_THREADS @@ -2824,12 +2830,12 @@ rspamd_libs_reset_decompression(struct rspamd_external_libs_ctx *ctx) return FALSE; } else { - r = ZSTD_DCtx_reset(ctx->in_zstream, ZSTD_reset_session_only); + r = ZSTD_DCtx_reset((ZSTD_DCtx *) ctx->in_zstream, ZSTD_reset_session_only); if (ZSTD_isError(r)) { msg_err("cannot init decompression stream: %s", ZSTD_getErrorName(r)); - ZSTD_freeDStream(ctx->in_zstream); + ZSTD_freeDStream((ZSTD_DCtx *) ctx->in_zstream); ctx->in_zstream = nullptr; return FALSE; @@ -2849,15 +2855,15 @@ rspamd_libs_reset_compression(struct rspamd_external_libs_ctx *ctx) } else { /* Dictionary will be reused automatically if specified */ - r = ZSTD_CCtx_reset(ctx->out_zstream, ZSTD_reset_session_only); + r = ZSTD_CCtx_reset((ZSTD_CCtx *) ctx->out_zstream, ZSTD_reset_session_only); if (!ZSTD_isError(r)) { - r = ZSTD_CCtx_setPledgedSrcSize(ctx->out_zstream, ZSTD_CONTENTSIZE_UNKNOWN); + r = ZSTD_CCtx_setPledgedSrcSize((ZSTD_CCtx *) ctx->out_zstream, ZSTD_CONTENTSIZE_UNKNOWN); } if (ZSTD_isError(r)) { msg_err("cannot init compression stream: %s", ZSTD_getErrorName(r)); - ZSTD_freeCStream(ctx->out_zstream); + ZSTD_freeCStream((ZSTD_CCtx *) ctx->out_zstream); ctx->out_zstream = nullptr; return FALSE; @@ -2883,11 +2889,11 @@ void rspamd_deinit_libs(struct rspamd_external_libs_ctx *ctx) rspamd_free_zstd_dictionary(ctx->out_dict); if (ctx->out_zstream) { - ZSTD_freeCStream(ctx->out_zstream); + ZSTD_freeCStream((ZSTD_CCtx *) ctx->out_zstream); } if (ctx->in_zstream) { - ZSTD_freeDStream(ctx->in_zstream); + ZSTD_freeDStream((ZSTD_DCtx *) ctx->in_zstream); } rspamd_cryptobox_deinit(ctx->crypto_ctx); diff --git a/src/libserver/dynamic_cfg.c b/src/libserver/dynamic_cfg.c index 8254ebc91..cd5cc4e30 100644 --- a/src/libserver/dynamic_cfg.c +++ b/src/libserver/dynamic_cfg.c @@ -1,11 +1,11 @@ -/*- - * Copyright 2016 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -36,7 +36,7 @@ struct config_json_buf { static void apply_dynamic_conf(const ucl_object_t *top, struct rspamd_config *cfg) { - gint test_act; + enum rspamd_action_type test_act; const ucl_object_t *cur_elt, *cur_nm, *it_val; ucl_object_iter_t it = NULL; const gchar *name; diff --git a/src/libserver/rspamd_symcache.h b/src/libserver/rspamd_symcache.h index f2f95fcc5..45e460c11 100644 --- a/src/libserver/rspamd_symcache.h +++ b/src/libserver/rspamd_symcache.h @@ -1,11 +1,11 @@ -/*- - * Copyright 2016 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -123,7 +123,7 @@ gint rspamd_symcache_add_symbol(struct rspamd_symcache *cache, gint priority, symbol_func_t func, gpointer user_data, - enum rspamd_symbol_type type, + int type, gint parent); /** diff --git a/src/libserver/symcache/symcache_c.cxx b/src/libserver/symcache/symcache_c.cxx index 52881f77e..06801d244 100644 --- a/src/libserver/symcache/symcache_c.cxx +++ b/src/libserver/symcache/symcache_c.cxx @@ -1,11 +1,11 @@ -/*- - * Copyright 2022 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -63,7 +63,7 @@ gint rspamd_symcache_add_symbol(struct rspamd_symcache *cache, gint priority, symbol_func_t func, gpointer user_data, - enum rspamd_symbol_type type, + int type, gint parent) { auto *real_cache = C_API_SYMCACHE(cache); diff --git a/src/libserver/symcache/symcache_impl.cxx b/src/libserver/symcache/symcache_impl.cxx index 94e90751b..5e0612587 100644 --- a/src/libserver/symcache/symcache_impl.cxx +++ b/src/libserver/symcache/symcache_impl.cxx @@ -1,11 +1,11 @@ -/*- - * Copyright 2022 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -717,7 +717,7 @@ auto symcache::add_symbol_with_callback(std::string_view name, int priority, symbol_func_t func, void *user_data, - enum rspamd_symbol_type flags_and_type) -> int + int flags_and_type) -> int { auto real_type_pair_maybe = item_type_from_c(flags_and_type); @@ -786,7 +786,7 @@ auto symcache::add_symbol_with_callback(std::string_view name, return id; } -auto symcache::add_virtual_symbol(std::string_view name, int parent_id, enum rspamd_symbol_type flags_and_type) -> int +auto symcache::add_virtual_symbol(std::string_view name, int parent_id, int flags_and_type) -> int { if (name.empty()) { msg_err_cache("cannot register a virtual symbol with no name; qed"); diff --git a/src/libserver/symcache/symcache_internal.hxx b/src/libserver/symcache/symcache_internal.hxx index 240939780..255a4b1c1 100644 --- a/src/libserver/symcache/symcache_internal.hxx +++ b/src/libserver/symcache/symcache_internal.hxx @@ -1,11 +1,11 @@ -/*- - * Copyright 2022 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -458,7 +458,7 @@ public: int priority, symbol_func_t func, void *user_data, - enum rspamd_symbol_type flags_and_type) -> int; + int flags_and_type) -> int; /** * A method to add a generic virtual symbol with no function associated * @param name must have some value, or a fatal error will strike you @@ -467,7 +467,7 @@ public: * @return id of a new symbol or -1 in case of failure */ auto add_virtual_symbol(std::string_view name, int parent_id, - enum rspamd_symbol_type flags_and_type) -> int; + int flags_and_type) -> int; /** * Sets a lua callback to be called on peaks in execution time diff --git a/src/libserver/symcache/symcache_item.cxx b/src/libserver/symcache/symcache_item.cxx index a468aaf03..24e198dd3 100644 --- a/src/libserver/symcache/symcache_item.cxx +++ b/src/libserver/symcache/symcache_item.cxx @@ -1,11 +1,11 @@ -/*- - * Copyright 2022 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -537,7 +537,7 @@ auto virtual_item::resolve_parent(const symcache &cache) -> bool return false; } -auto item_type_from_c(enum rspamd_symbol_type type) -> tl::expected, std::string> +auto item_type_from_c(int type) -> tl::expected, std::string> { constexpr const auto trivial_types = SYMBOL_TYPE_CONNFILTER | SYMBOL_TYPE_PREFILTER | SYMBOL_TYPE_POSTFILTER | SYMBOL_TYPE_IDEMPOTENT | SYMBOL_TYPE_COMPOSITE | SYMBOL_TYPE_CLASSIFIER | SYMBOL_TYPE_VIRTUAL; diff --git a/src/libserver/symcache/symcache_item.hxx b/src/libserver/symcache/symcache_item.hxx index 5ceffa121..c159e7c47 100644 --- a/src/libserver/symcache/symcache_item.hxx +++ b/src/libserver/symcache/symcache_item.hxx @@ -1,11 +1,11 @@ -/*- - * Copyright 2022 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -85,7 +85,7 @@ constexpr static auto item_type_to_str(symcache_item_type t) -> const char * * @param type input type as a C enum * @return pair of type safe symcache_item_type + the remaining flags or an error */ -auto item_type_from_c(enum rspamd_symbol_type type) -> tl::expected, std::string>; +auto item_type_from_c(int type) -> tl::expected, std::string>; struct item_condition { private: diff --git a/src/libutil/mem_pool.c b/src/libutil/mem_pool.c index a348bcaaa..12fb761b1 100644 --- a/src/libutil/mem_pool.c +++ b/src/libutil/mem_pool.c @@ -621,7 +621,7 @@ rspamd_mempool_strdup_(rspamd_mempool_t *pool, const gchar *src, const gchar *lo } gchar * -rspamd_mempool_ftokdup_(rspamd_mempool_t *pool, struct f_str_tok src, +rspamd_mempool_ftokdup_(rspamd_mempool_t *pool, const rspamd_ftok_t *src, const gchar *loc) { gchar *newstr; diff --git a/src/libutil/mem_pool.h b/src/libutil/mem_pool.h index 8c253efe7..e3bb2b5cd 100644 --- a/src/libutil/mem_pool.h +++ b/src/libutil/mem_pool.h @@ -226,7 +226,7 @@ struct f_str_tok; * @return pointer to newly created string that is copy of src */ gchar *rspamd_mempool_ftokdup_(rspamd_mempool_t *pool, - struct f_str_tok src, + const struct f_str_tok *src, const gchar *loc) RSPAMD_ATTR_ALLOC_ALIGN(MIN_MEM_ALIGNMENT); #define rspamd_mempool_ftokdup(pool, src) \ diff --git a/src/lua/lua_common.h b/src/lua/lua_common.h index 32b61dcf8..cc2b94390 100644 --- a/src/lua/lua_common.h +++ b/src/lua/lua_common.h @@ -427,15 +427,6 @@ double rspamd_lua_normalize(struct rspamd_config *cfg, /* Config file functions */ void rspamd_lua_post_load_config(struct rspamd_config *cfg); -gboolean rspamd_lua_handle_param(struct rspamd_task *task, - gchar *mname, - gchar *optname, - enum lua_var_type expected_type, - gpointer *res); - -gboolean rspamd_lua_check_condition(struct rspamd_config *cfg, - const gchar *condition); - void rspamd_lua_dumpstack(lua_State *L); /* Set lua path according to the configuration */ diff --git a/src/rspamd.h b/src/rspamd.h index b3aef558b..8c92e1818 100644 --- a/src/rspamd.h +++ b/src/rspamd.h @@ -1,11 +1,11 @@ -/*- - * Copyright 2016-2017 Vsevolod Stakhov +/* + * Copyright 2023 Vsevolod Stakhov * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, @@ -352,8 +352,8 @@ struct rspamd_external_libs_ctx { void **local_addrs; struct rspamd_cryptobox_library_ctx *crypto_ctx; struct ottery_config *ottery_cfg; - SSL_CTX *ssl_ctx; - SSL_CTX *ssl_ctx_noverify; + void *ssl_ctx; + void *ssl_ctx_noverify; struct zstd_dictionary *in_dict; struct zstd_dictionary *out_dict; void *out_zstream;