From: Scott González Date: Wed, 20 Aug 2014 20:04:54 +0000 (-0400) Subject: Accordion: Avoid memory leak during refresh X-Git-Tag: 1.11.2~37 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=849c6fd5376e12c6093c557bd4836ef0b145f145;p=jquery-ui.git Accordion: Avoid memory leak during refresh Ref #10056 Closes gh-1319 --- diff --git a/ui/accordion.js b/ui/accordion.js index 5b748a3f2..946437197 100644 --- a/ui/accordion.js +++ b/ui/accordion.js @@ -259,13 +259,22 @@ return $.widget( "ui.accordion", { }, _processPanels: function() { + var prevHeaders = this.headers, + prevPanels = this.panels; + this.headers = this.element.find( this.options.header ) .addClass( "ui-accordion-header ui-state-default ui-corner-all" ); - this.headers.next() + this.panels = this.headers.next() .addClass( "ui-accordion-content ui-helper-reset ui-widget-content ui-corner-bottom" ) .filter( ":not(.ui-accordion-content-active)" ) .hide(); + + // Avoid memory leaks (#10056) + if ( prevPanels ) { + this._off( prevHeaders.not( this.headers ) ); + this._off( prevPanels.not( this.panels ) ); + } }, _refresh: function() {