From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Tue, 21 Sep 2021 18:22:26 +0000 (+0100)
Subject: [Minor] Fix use after free
X-Git-Tag: 3.1~129
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=86e6cb7edb28d01dd888db9d38ef7c14978d56d3;p=rspamd.git

[Minor] Fix use after free

Reported by: @citrin
---

diff --git a/src/libserver/re_cache.c b/src/libserver/re_cache.c
index 631981b30..4d631da01 100644
--- a/src/libserver/re_cache.c
+++ b/src/libserver/re_cache.c
@@ -2065,15 +2065,15 @@ rspamd_re_cache_compile_timer_cb (EV_P_ ev_timer *w, int revents )
 				g_free (hs_pats[j]);
 			}
 
+			err = g_error_new (rspamd_re_cache_quark (), EINVAL,
+					"cannot create tree of regexp when processing '%s': %s",
+					hs_pats[hs_errors->expression], hs_errors->message);
 			g_free (hs_pats);
 			g_free (hs_exts);
 			close (fd);
 			unlink (path);
 			hs_free_compile_error (hs_errors);
 
-			err = g_error_new (rspamd_re_cache_quark (), EINVAL,
-					"cannot create tree of regexp when processing '%s': %s",
-					hs_pats[hs_errors->expression], hs_errors->message);
 			rspamd_re_cache_compile_err (EV_A_ w, err, cbdata);
 
 			return;