From: Grégoire Aubert <gregoire.aubert@sonarsource.com>
Date: Fri, 20 Oct 2017 14:40:03 +0000 (+0200)
Subject: SONAR-9504 Support ESC keyboard shortcut to skip onboarding tuto from anywhere on... 
X-Git-Tag: 6.7-RC1~125
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8798cc1df59ef804c17d9e77f63c00c14ebcbddc;p=sonarqube.git

SONAR-9504 Support ESC keyboard shortcut to skip onboarding tuto from anywhere on the tuto
---

diff --git a/server/sonar-web/src/main/js/apps/tutorials/onboarding/Onboarding.js b/server/sonar-web/src/main/js/apps/tutorials/onboarding/Onboarding.js
index ad825f28a36..5a1ea7dcaa6 100644
--- a/server/sonar-web/src/main/js/apps/tutorials/onboarding/Onboarding.js
+++ b/server/sonar-web/src/main/js/apps/tutorials/onboarding/Onboarding.js
@@ -21,7 +21,6 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import Helmet from 'react-helmet';
-import key from 'keymaster';
 import TokenStep from './TokenStep';
 import OrganizationStep from './OrganizationStep';
 import AnalysisStep from './AnalysisStep';
@@ -72,28 +71,26 @@ export default class Onboarding extends React.PureComponent {
 
   componentDidMount() {
     this.mounted = true;
-    this.attachShortcuts();
+
+    // useCapture = true to receive the event before inputs
+    window.addEventListener('keydown', this.onKeyDown, true);
+
     if (!this.props.currentUser.isLoggedIn) {
       handleRequiredAuthentication();
     }
   }
 
   componentWillUnmount() {
+    window.removeEventListener('keydown', this.onKeyDown, true);
     this.mounted = false;
-    this.detachShortcuts();
   }
 
-  attachShortcuts() {
-    key.setScope('onboarding');
-    key('esc', 'onboarding', () => {
+  onKeyDown = (event /*: KeyboardEvent */) => {
+    // ESC key
+    if (event.keyCode === 27) {
       this.finishOnboarding();
-      return false;
-    });
-  }
-
-  detachShortcuts() {
-    key.deleteScope('onboarding');
-  }
+    }
+  };
 
   finishOnboarding = () => {
     this.setState({ skipping: true });