From: Jörn Friedrich Dreyer <jfd@butonic.de>
Date: Tue, 31 Mar 2015 12:56:02 +0000 (+0200)
Subject: do not disclose information, show generic error on login page
X-Git-Tag: v8.1.0alpha1~33^2~8
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8964c5068cec5d56ef5107c4cbcb10e55e4ef4a5;p=nextcloud-server.git

do not disclose information, show generic error on login page

Conflicts:
	core/templates/login.php
	lib/base.php
---

diff --git a/core/templates/login.php b/core/templates/login.php
index 0ef7882d4b0..b24c9cb07d0 100644
--- a/core/templates/login.php
+++ b/core/templates/login.php
@@ -24,6 +24,12 @@ script('core', [
 				<?php p($message); ?><br>
 			</div>
 		<?php endforeach; ?>
+		<?php if (isset($_['internalexception']) && ($_['internalexception'])): ?>
+			<div class="warning">
+				<?php p($l->t('An internal error occured.')); ?><br>
+				<small><?php p($l->t('Please try again or contact your administrator.')); ?></small>
+			</div>
+		<?php endif; ?>
 		<p id="message" class="hidden">
 			<img class="float-spinner" alt=""
 				src="<?php p(\OCP\Util::imagePath('core', 'loading-dark.gif'));?>">
diff --git a/lib/base.php b/lib/base.php
index 042419eff1d..82282c7dabd 100644
--- a/lib/base.php
+++ b/lib/base.php
@@ -957,6 +957,10 @@ class OC {
 			}
 		} catch (\OC\User\LoginException $e) {
 			$messages[] = $e->getMessage();
+		} catch (\Exception $ex) {
+			\OCP\Util::logException('handleLogin', $ex);
+			// do not disclose information. show generic error
+			$error[] = 'internalexception';
 		}
 
 		OC_Util::displayLoginPage(array_unique($error), $messages);