From: Alexander Moisseev Date: Sun, 15 Jul 2018 10:14:06 +0000 (+0300) Subject: [Minor] Do not reassign function parameters X-Git-Tag: 1.7.9~119^2~3 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=89bfbd940c9f5d96de3dd661fc43f3fbd75ccc27;p=rspamd.git [Minor] Do not reassign function parameters --- diff --git a/.eslintrc.json b/.eslintrc.json index 80303639e..b4f242a41 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -49,7 +49,6 @@ // Temporarily disabled rules "array-callback-return": "off", "array-element-newline": "off", - "block-scoped-var": "off", "brace-style": "off", "callback-return": "off", "consistent-return": "off", @@ -74,7 +73,6 @@ "no-invalid-this": "off", "no-loop-func": "off", "no-negated-condition": "off", - "no-param-reassign": "off", "no-underscore-dangle": "off", "no-use-before-define": "off", "one-var-declaration-per-line": "off", diff --git a/interface/js/app/rspamd.js b/interface/js/app/rspamd.js index 708de27ae..b5d44b9f9 100644 --- a/interface/js/app/rspamd.js +++ b/interface/js/app/rspamd.js @@ -79,7 +79,8 @@ function ($, d3pie, visibility, tab_stat, tab_graph, tab_config, ui.connect(); } - function tabClick(tab_id) { + function tabClick(id) { + var tab_id = id; if ($(tab_id).attr("disabled")) return; $(tab_id).attr("disabled", true); @@ -387,9 +388,8 @@ function ($, d3pie, visibility, tab_stat, tab_graph, tab_config, }); }); $.each(neighbours_status, function (ind) { - method = typeof method !== "undefined" ? method : "GET"; var req_params = { - type: method, + type: typeof method !== "undefined" ? method : "GET", jsonp: false, data: req_data, beforeSend: function (xhr) { @@ -457,7 +457,8 @@ function ($, d3pie, visibility, tab_stat, tab_graph, tab_config, }); }; - ui.drawPie = function (obj, id, data, conf) { + ui.drawPie = function (object, id, data, conf) { + var obj = object; if (obj) { obj.updateProp("data.content", data.filter(function (elt) {