From: Julien Lancelot <julien.lancelot@sonarsource.com>
Date: Tue, 21 Nov 2017 13:47:15 +0000 (+0100)
Subject: SONAR-10087 Add built-in flag to provided quality gate
X-Git-Tag: 7.0-RC1~245
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8ae01aa5e760fe236fabe57d3e2ffa68dd66e786;p=sonarqube.git

SONAR-10087 Add built-in flag to provided quality gate
---

diff --git a/server/sonar-ce/src/test/java/org/sonar/ce/container/ComputeEngineContainerImplTest.java b/server/sonar-ce/src/test/java/org/sonar/ce/container/ComputeEngineContainerImplTest.java
index c692eed52f4..950cbde71b7 100644
--- a/server/sonar-ce/src/test/java/org/sonar/ce/container/ComputeEngineContainerImplTest.java
+++ b/server/sonar-ce/src/test/java/org/sonar/ce/container/ComputeEngineContainerImplTest.java
@@ -109,8 +109,8 @@ public class ComputeEngineContainerImplTest {
     );
     assertThat(picoContainer.getParent().getParent().getComponentAdapters()).hasSize(
       CONTAINER_ITSELF
+        + 14 // MigrationConfigurationModule
         + 17 // level 2
-        + 13 // MigrationConfigurationModule
     );
     assertThat(picoContainer.getParent().getParent().getParent().getComponentAdapters()).hasSize(
       COMPONENTS_IN_LEVEL_1_AT_CONSTRUCTION
diff --git a/server/sonar-db-core/src/main/resources/org/sonar/db/version/schema-h2.ddl b/server/sonar-db-core/src/main/resources/org/sonar/db/version/schema-h2.ddl
index f3bedc4ba6b..733e8d5f09d 100644
--- a/server/sonar-db-core/src/main/resources/org/sonar/db/version/schema-h2.ddl
+++ b/server/sonar-db-core/src/main/resources/org/sonar/db/version/schema-h2.ddl
@@ -229,6 +229,7 @@ CREATE UNIQUE INDEX "EVENTS_UUID" ON "EVENTS" ("UUID");
 CREATE TABLE "QUALITY_GATES" (
   "ID" INTEGER NOT NULL GENERATED BY DEFAULT AS IDENTITY (START WITH 1, INCREMENT BY 1),
   "NAME" VARCHAR(100) NOT NULL,
+  "IS_BUILT_IN" BOOLEAN NULL,
   "CREATED_AT" TIMESTAMP,
   "UPDATED_AT" TIMESTAMP,
 );
diff --git a/server/sonar-db-dao/src/main/java/org/sonar/db/qualitygate/QualityGateDto.java b/server/sonar-db-dao/src/main/java/org/sonar/db/qualitygate/QualityGateDto.java
index 98832bbfaae..2e0d294825c 100644
--- a/server/sonar-db-dao/src/main/java/org/sonar/db/qualitygate/QualityGateDto.java
+++ b/server/sonar-db-dao/src/main/java/org/sonar/db/qualitygate/QualityGateDto.java
@@ -27,11 +27,9 @@ import java.util.Date;
 public class QualityGateDto {
 
   private Long id;
-
   private String name;
-
+  private boolean isBuiltIn;
   private Date createdAt;
-
   private Date updatedAt;
 
   public Long getId() {
@@ -52,6 +50,15 @@ public class QualityGateDto {
     return this;
   }
 
+  public boolean isBuiltIn() {
+    return isBuiltIn;
+  }
+
+  public QualityGateDto setBuiltIn(boolean builtIn) {
+    isBuiltIn = builtIn;
+    return this;
+  }
+
   public Date getCreatedAt() {
     return createdAt;
   }
diff --git a/server/sonar-db-dao/src/main/resources/org/sonar/db/qualitygate/QualityGateMapper.xml b/server/sonar-db-dao/src/main/resources/org/sonar/db/qualitygate/QualityGateMapper.xml
index 0dfb59d5d08..290a4966886 100644
--- a/server/sonar-db-dao/src/main/resources/org/sonar/db/qualitygate/QualityGateMapper.xml
+++ b/server/sonar-db-dao/src/main/resources/org/sonar/db/qualitygate/QualityGateMapper.xml
@@ -4,12 +4,12 @@
 <mapper namespace="org.sonar.db.qualitygate.QualityGateMapper">
 
   <insert id="insert" parameterType="QualityGate" keyColumn="id" useGeneratedKeys="true" keyProperty="id">
-    insert into quality_gates (name, created_at, updated_at)
-    values (#{name}, #{createdAt}, #{updatedAt})
+    insert into quality_gates (name, is_built_in, created_at, updated_at)
+    values (#{name}, #{isBuiltIn}, #{createdAt}, #{updatedAt})
   </insert>
 
   <sql id="gateColumns">
-    id, name, created_at as createdAt, updated_at as updatedAt
+    id, name, is_built_in as isBuiltIn, created_at as createdAt, updated_at as updatedAt
   </sql>
 
   <select id="selectAll" resultType="QualityGate">
diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDaoTest.java
index 834cde95798..fc1a907e786 100644
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDaoTest.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDaoTest.java
@@ -32,26 +32,35 @@ import static org.assertj.core.api.Assertions.assertThat;
 public class QualityGateDaoTest {
 
   @Rule
-  public DbTester dbTester = DbTester.create(System2.INSTANCE);
+  public DbTester db = DbTester.create(System2.INSTANCE);
 
-  private DbSession dbSession = dbTester.getSession();
-  private QualityGateDao underTest = dbTester.getDbClient().qualityGateDao();
+  private DbSession dbSession = db.getSession();
+  private QualityGateDao underTest = db.getDbClient().qualityGateDao();
 
   @Test
   public void testInsert() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "insert.xml");
+    db.prepareDbUnit(getClass(), "insert.xml");
     QualityGateDto newQgate = new QualityGateDto().setName("My Quality Gate");
 
     underTest.insert(dbSession, newQgate);
     dbSession.commit();
 
-    dbTester.assertDbUnitTable(getClass(), "insert-result.xml", "quality_gates", "name");
+    db.assertDbUnitTable(getClass(), "insert-result.xml", "quality_gates", "name");
     assertThat(newQgate.getId()).isNotNull();
   }
 
+  @Test
+  public void insert_built_in() {
+    underTest.insert(db.getSession(), new QualityGateDto().setName("test").setBuiltIn(true));
+
+    QualityGateDto reloaded = underTest.selectByName(db.getSession(), "test");
+
+    assertThat(reloaded.isBuiltIn()).isTrue();
+  }
+
   @Test
   public void testSelectAll() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "selectAll.xml");
+    db.prepareDbUnit(getClass(), "selectAll.xml");
 
     Collection<QualityGateDto> allQualityGates = underTest.selectAll(dbSession);
 
@@ -64,35 +73,35 @@ public class QualityGateDaoTest {
 
   @Test
   public void testSelectByName() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "selectAll.xml");
+    db.prepareDbUnit(getClass(), "selectAll.xml");
     assertThat(underTest.selectByName(dbSession, "Balanced").getName()).isEqualTo("Balanced");
     assertThat(underTest.selectByName(dbSession, "Unknown")).isNull();
   }
 
   @Test
   public void testSelectById() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "selectAll.xml");
+    db.prepareDbUnit(getClass(), "selectAll.xml");
     assertThat(underTest.selectById(dbSession, 1L).getName()).isEqualTo("Very strict");
     assertThat(underTest.selectById(dbSession, 42L)).isNull();
   }
 
   @Test
   public void testDelete() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "selectAll.xml");
+    db.prepareDbUnit(getClass(), "selectAll.xml");
 
     underTest.delete(new QualityGateDto().setId(1L), dbSession);
     dbSession.commit();
 
-    dbTester.assertDbUnitTable(getClass(), "delete-result.xml", "quality_gates", "id", "name");
+    db.assertDbUnitTable(getClass(), "delete-result.xml", "quality_gates", "id", "name");
   }
 
   @Test
   public void testUpdate() throws Exception {
-    dbTester.prepareDbUnit(getClass(), "selectAll.xml");
+    db.prepareDbUnit(getClass(), "selectAll.xml");
 
     underTest.update(new QualityGateDto().setId(1L).setName("Not so strict"), dbSession);
     dbSession.commit();
 
-    dbTester.assertDbUnitTable(getClass(), "update-result.xml", "quality_gates", "id", "name");
+    db.assertDbUnitTable(getClass(), "update-result.xml", "quality_gates", "id", "name");
   }
 }
diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDbTester.java b/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDbTester.java
index 78136a89b35..5b08337d215 100644
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDbTester.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/qualitygate/QualityGateDbTester.java
@@ -46,7 +46,7 @@ public class QualityGateDbTester {
   }
 
   public QualityGateDto insertQualityGate(String name) {
-    QualityGateDto updatedUser = dbClient.qualityGateDao().insert(dbSession, new QualityGateDto().setName(name));
+    QualityGateDto updatedUser = dbClient.qualityGateDao().insert(dbSession, new QualityGateDto().setName(name).setBuiltIn(false));
     db.commit();
     return updatedUser;
   }
diff --git a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/ProjectQgateAssociationDaoTest/shared.xml b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/ProjectQgateAssociationDaoTest/shared.xml
index 3b4ee850ea7..6ef7233011a 100644
--- a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/ProjectQgateAssociationDaoTest/shared.xml
+++ b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/ProjectQgateAssociationDaoTest/shared.xml
@@ -1,9 +1,9 @@
 <dataset>
 
   <quality_gates id="42"
-                 name="Golden"/>
+                 name="Golden" is_built_in="[true]"/>
   <quality_gates id="43"
-                 name="Ninth"/>
+                 name="Ninth" is_built_in="[false]"/>
 
   <projects organization_uuid="org1"
             uuid="A"
diff --git a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/delete-result.xml b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/delete-result.xml
index 3c0ddc793c1..67f4fafc965 100644
--- a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/delete-result.xml
+++ b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/delete-result.xml
@@ -1,6 +1,6 @@
 <dataset>
 
-  <quality_gates id="2" name="Balanced"/>
-  <quality_gates id="3" name="Lenient"/>
+  <quality_gates id="2" name="Balanced" is_built_in="[false]"/>
+  <quality_gates id="3" name="Lenient" is_built_in="[false]"/>
 
 </dataset>
diff --git a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/insert-result.xml b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/insert-result.xml
index 00881f2945b..00c28571e9d 100644
--- a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/insert-result.xml
+++ b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/insert-result.xml
@@ -1,5 +1,5 @@
 <dataset>
 
-  <quality_gates id="1" name="My Quality Gate"/>
+  <quality_gates id="1" name="My Quality Gate" is_built_in="[false]"/>
 
 </dataset>
diff --git a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/selectAll.xml b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/selectAll.xml
index 6eb3e577e4e..09799b3114b 100644
--- a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/selectAll.xml
+++ b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/selectAll.xml
@@ -1,7 +1,7 @@
 <dataset>
 
-  <quality_gates id="1" name="Very strict"/>
-  <quality_gates id="2" name="Balanced"/>
-  <quality_gates id="3" name="Lenient"/>
+  <quality_gates id="1" name="Very strict" is_built_in="[true]"/>
+  <quality_gates id="2" name="Balanced" is_built_in="[false]"/>
+  <quality_gates id="3" name="Lenient" is_built_in="[false]"/>
 
 </dataset>
diff --git a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/update-result.xml b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/update-result.xml
index 4f80f313eae..6dfb4819362 100644
--- a/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/update-result.xml
+++ b/server/sonar-db-dao/src/test/resources/org/sonar/db/qualitygate/QualityGateDaoTest/update-result.xml
@@ -1,7 +1,7 @@
 <dataset>
 
-  <quality_gates id="1" name="Not so strict"/>
-  <quality_gates id="2" name="Balanced"/>
-  <quality_gates id="3" name="Lenient"/>
+  <quality_gates id="1" name="Not so strict" is_built_in="[false]"/>
+  <quality_gates id="2" name="Balanced" is_built_in="[false]"/>
+  <quality_gates id="3" name="Lenient" is_built_in="[false]"/>
 
 </dataset>
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/MigrationConfigurationModule.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/MigrationConfigurationModule.java
index 5f7026a9b4d..87bf06403aa 100644
--- a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/MigrationConfigurationModule.java
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/MigrationConfigurationModule.java
@@ -33,6 +33,7 @@ import org.sonar.server.platform.db.migration.version.v64.DbVersion64;
 import org.sonar.server.platform.db.migration.version.v65.DbVersion65;
 import org.sonar.server.platform.db.migration.version.v66.DbVersion66;
 import org.sonar.server.platform.db.migration.version.v67.DbVersion67;
+import org.sonar.server.platform.db.migration.version.v70.DbVersion70;
 
 public class MigrationConfigurationModule extends Module {
   @Override
@@ -49,6 +50,7 @@ public class MigrationConfigurationModule extends Module {
       DbVersion65.class,
       DbVersion66.class,
       DbVersion67.class,
+      DbVersion70.class,
 
       // migration steps
       MigrationStepRegistryImpl.class,
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGates.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGates.java
new file mode 100644
index 00000000000..e82657355fd
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGates.java
@@ -0,0 +1,45 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+package org.sonar.server.platform.db.migration.version.v70;
+
+import java.sql.SQLException;
+import org.sonar.db.Database;
+import org.sonar.server.platform.db.migration.sql.AddColumnsBuilder;
+import org.sonar.server.platform.db.migration.step.DdlChange;
+
+import static org.sonar.server.platform.db.migration.def.BooleanColumnDef.newBooleanColumnDefBuilder;
+
+public class AddIsBuiltInToQualityGates extends DdlChange {
+
+  public AddIsBuiltInToQualityGates(Database db) {
+    super(db);
+  }
+
+  @Override
+  public void execute(Context context) throws SQLException {
+    context.execute(new AddColumnsBuilder(getDialect(), "quality_gates")
+      .addColumn(newBooleanColumnDefBuilder()
+        .setColumnName("is_built_in")
+        .setIsNullable(true)
+        .build())
+      .build());
+  }
+}
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70.java
new file mode 100644
index 00000000000..48c677f007e
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70.java
@@ -0,0 +1,33 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v70;
+
+import org.sonar.server.platform.db.migration.step.MigrationStepRegistry;
+import org.sonar.server.platform.db.migration.version.DbVersion;
+
+public class DbVersion70 implements DbVersion {
+
+  @Override
+  public void addSteps(MigrationStepRegistry registry) {
+    registry
+      .add(1900, "Add QUALITY_GATES.IS_BUILT_IN", AddIsBuiltInToQualityGates.class);
+  }
+
+}
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/package-info.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/package-info.java
new file mode 100644
index 00000000000..78095d8cab4
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v70/package-info.java
@@ -0,0 +1,24 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+@ParametersAreNonnullByDefault
+package org.sonar.server.platform.db.migration.version.v70;
+
+import javax.annotation.ParametersAreNonnullByDefault;
+
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/MigrationConfigurationModuleTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/MigrationConfigurationModuleTest.java
index 313c1dec0ea..6c41663182c 100644
--- a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/MigrationConfigurationModuleTest.java
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/MigrationConfigurationModuleTest.java
@@ -37,7 +37,7 @@ public class MigrationConfigurationModuleTest {
     assertThat(container.getPicoContainer().getComponentAdapters())
       .hasSize(COMPONENTS_IN_EMPTY_COMPONENT_CONTAINER
         // DbVersion classes
-        + 10
+        + 11
         // Others
         + 3);
   }
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest.java
new file mode 100644
index 00000000000..3cdfb04724b
--- /dev/null
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest.java
@@ -0,0 +1,56 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v70;
+
+import java.sql.SQLException;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+import org.sonar.db.CoreDbTester;
+
+import static java.sql.Types.BOOLEAN;
+
+public class AddIsBuiltInToQualityGatesTest {
+
+  @Rule
+  public final CoreDbTester dbTester = CoreDbTester.createForSchema(AddIsBuiltInToQualityGatesTest.class, "quality_gates_7_0.sql");
+
+  @Rule
+  public ExpectedException expectedException = ExpectedException.none();
+
+  private AddIsBuiltInToQualityGates underTest = new AddIsBuiltInToQualityGates(dbTester.database());
+
+  @Test
+  public void column_is_added_to_table() throws SQLException {
+    underTest.execute();
+
+    dbTester.assertColumnDefinition("quality_gates", "is_built_in", BOOLEAN, null, true);
+  }
+
+  @Test
+  public void migration_is_not_reentrant() throws SQLException {
+    underTest.execute();
+
+    expectedException.expect(IllegalStateException.class);
+
+    underTest.execute();
+  }
+
+}
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70Test.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70Test.java
new file mode 100644
index 00000000000..f28d675304d
--- /dev/null
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v70/DbVersion70Test.java
@@ -0,0 +1,41 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v70;
+
+import org.junit.Test;
+
+import static org.sonar.server.platform.db.migration.version.DbVersionTestUtils.verifyMigrationCount;
+import static org.sonar.server.platform.db.migration.version.DbVersionTestUtils.verifyMinimumMigrationNumber;
+
+public class DbVersion70Test {
+
+  private DbVersion70 underTest = new DbVersion70();
+
+  @Test
+  public void migrationNumber_starts_at_1830() {
+    verifyMinimumMigrationNumber(underTest, 1900);
+  }
+
+  @Test
+  public void verify_migration_count() {
+    verifyMigrationCount(underTest, 1);
+  }
+
+}
diff --git a/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest/quality_gates_7_0.sql b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest/quality_gates_7_0.sql
new file mode 100644
index 00000000000..811a5d45965
--- /dev/null
+++ b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v70/AddIsBuiltInToQualityGatesTest/quality_gates_7_0.sql
@@ -0,0 +1,7 @@
+CREATE TABLE "QUALITY_GATES" (
+  "ID" INTEGER NOT NULL GENERATED BY DEFAULT AS IDENTITY (START WITH 1, INCREMENT BY 1),
+  "NAME" VARCHAR(100) NOT NULL,
+  "CREATED_AT" TIMESTAMP,
+  "UPDATED_AT" TIMESTAMP,
+);
+CREATE UNIQUE INDEX "UNIQ_QUALITY_GATES" ON "QUALITY_GATES" ("NAME");
diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/RegisterQualityGates.java b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/RegisterQualityGates.java
index 24f161e79dd..05394b65ed6 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/RegisterQualityGates.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/RegisterQualityGates.java
@@ -41,15 +41,13 @@ public class RegisterQualityGates implements Startable {
   private static final int LEAK_PERIOD = 1;
 
   private final DbClient dbClient;
-  private final QualityGateUpdater qualityGateUpdater;
   private final QualityGateConditionsUpdater qualityGateConditionsUpdater;
   private final LoadedTemplateDao loadedTemplateDao;
   private final QualityGates qualityGates;
 
-  public RegisterQualityGates(DbClient dbClient, QualityGateUpdater qualityGateUpdater, QualityGateConditionsUpdater qualityGateConditionsUpdater,
+  public RegisterQualityGates(DbClient dbClient, QualityGateConditionsUpdater qualityGateConditionsUpdater,
     LoadedTemplateDao loadedTemplateDao, QualityGates qualityGates) {
     this.dbClient = dbClient;
-    this.qualityGateUpdater = qualityGateUpdater;
     this.qualityGateConditionsUpdater = qualityGateConditionsUpdater;
     this.loadedTemplateDao = loadedTemplateDao;
     this.qualityGates = qualityGates;
@@ -77,7 +75,7 @@ public class RegisterQualityGates implements Startable {
 
   private void createBuiltinQualityGate(DbSession dbSession) {
     String ratingAValue = Integer.toString(RatingGrid.Rating.A.getIndex());
-    QualityGateDto builtin = qualityGateUpdater.create(dbSession, BUILTIN_QUALITY_GATE);
+    QualityGateDto builtin = createQualityGate(dbSession, BUILTIN_QUALITY_GATE);
     qualityGateConditionsUpdater.createCondition(dbSession, builtin.getId(),
       NEW_SECURITY_RATING_KEY, OPERATOR_GREATER_THAN, null, ratingAValue, LEAK_PERIOD);
     qualityGateConditionsUpdater.createCondition(dbSession, builtin.getId(),
@@ -91,6 +89,14 @@ public class RegisterQualityGates implements Startable {
     qualityGates.setDefault(dbSession, builtin.getId());
   }
 
+  private QualityGateDto createQualityGate(DbSession dbSession, String name){
+    QualityGateDto qualityGate = new QualityGateDto()
+      .setName(name)
+      .setBuiltIn(true);
+    dbClient.qualityGateDao().insert(dbSession, qualityGate);
+    return qualityGate;
+  }
+
   private void registerBuiltinQualityGate(DbSession dbSession) {
     loadedTemplateDao.insert(new LoadedTemplateDto(BUILTIN_QUALITY_GATE, LoadedTemplateDto.QUALITY_GATE_TYPE), dbSession);
   }
diff --git a/server/sonar-server/src/test/java/org/sonar/server/qualitygate/RegisterQualityGatesTest.java b/server/sonar-server/src/test/java/org/sonar/server/qualitygate/RegisterQualityGatesTest.java
index 5e3900543d0..79e661ada9d 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/qualitygate/RegisterQualityGatesTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/qualitygate/RegisterQualityGatesTest.java
@@ -58,7 +58,6 @@ public class RegisterQualityGatesTest {
 
   QualityGates qualityGates = mock(QualityGates.class);
   RegisterQualityGates task = new RegisterQualityGates(dbClient,
-    new QualityGateUpdater(dbClient),
     new QualityGateConditionsUpdater(dbClient),
     dbClient.loadedTemplateDao(),
     qualityGates);
@@ -77,6 +76,7 @@ public class RegisterQualityGatesTest {
     assertThat(dbClient.loadedTemplateDao().countByTypeAndKey("QUALITY_GATE", "SonarQube way", dbSession)).isEqualTo(1);
     QualityGateDto qualityGateDto = dbClient.qualityGateDao().selectByName(dbSession, "SonarQube way");
     assertThat(qualityGateDto).isNotNull();
+    assertThat(qualityGateDto.isBuiltIn()).isTrue();
     assertThat(dbClient.gateConditionDao().selectForQualityGate(dbSession, qualityGateDto.getId()))
       .extracting(QualityGateConditionDto::getMetricId, QualityGateConditionDto::getOperator, QualityGateConditionDto::getWarningThreshold,
         QualityGateConditionDto::getErrorThreshold, QualityGateConditionDto::getPeriod)