From: Jani Laakso <jani.laakso@itmill.com>
Date: Wed, 23 Apr 2008 13:41:14 +0000 (+0000)
Subject: Fixed #1590: AbstractComponentContainer and CustomComponent setCompositionRoot throws... 
X-Git-Tag: 6.7.0.beta1~4873
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8df611745ad8df4b5dab963c4f58d0866fb34b5e;p=vaadin-framework.git

Fixed #1590: AbstractComponentContainer and CustomComponent setCompositionRoot throws exception

svn changeset:4208/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/ui/CustomComponent.java b/src/com/itmill/toolkit/ui/CustomComponent.java
index 4815c3561b..cd5c6725d4 100644
--- a/src/com/itmill/toolkit/ui/CustomComponent.java
+++ b/src/com/itmill/toolkit/ui/CustomComponent.java
@@ -83,12 +83,16 @@ public class CustomComponent extends AbstractComponentContainer {
      *                the root of the composition component tree.
      */
     protected final void setCompositionRoot(Component compositionRoot) {
-        if (compositionRoot != root && root != null) {
-            super.removeComponent(root);
-        }
-        root = compositionRoot;
-        if (root != null) {
-            super.addComponent(root);
+        if (compositionRoot != root) {
+            if (root != null) {
+                // remove old component
+                super.removeComponent(root);
+            }
+            if (compositionRoot != null) {
+                // set new component
+                super.addComponent(compositionRoot);
+            }
+            root = compositionRoot;
         }
     }