From: James Moger Date: Mon, 15 Jul 2013 12:09:20 +0000 (-0400) Subject: Fixed url panel failure when there are no repository urls (issue 269) X-Git-Tag: v1.3.1~37 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8f6e672ffe19c439aadc07b64e36ae4b83e78f1e;p=gitblit.git Fixed url panel failure when there are no repository urls (issue 269) --- diff --git a/releases.moxie b/releases.moxie index d9e30358..3f07613a 100644 --- a/releases.moxie +++ b/releases.moxie @@ -9,7 +9,8 @@ r18: { html: ~ text: ~ security: ~ - fixes: ~ + fixes: + - Gitblit-as-viewer with no repository urls failed to display summary page (issue 269) changes: ~ additions: ~ dependencyChanges: ~ diff --git a/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java b/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java index 3711ca9a..aaab2b1c 100644 --- a/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java +++ b/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java @@ -85,7 +85,7 @@ public class RepositoryUrlPanel extends BasePanel { // grab primary url from the top of the list primaryUrl = repositoryUrls.size() == 0 ? null : repositoryUrls.get(0); - boolean canClone = ((primaryUrl.permission == null) || primaryUrl.permission.atLeast(AccessPermission.CLONE)); + boolean canClone = primaryUrl != null && ((primaryUrl.permission == null) || primaryUrl.permission.atLeast(AccessPermission.CLONE)); if (repositoryUrls.size() == 0 || !canClone) { // no urls, nothing to show.