From: David Serduke <davidserduke@gmail.com>
Date: Mon, 17 Dec 2007 16:54:44 +0000 (+0000)
Subject: Fixed #2062 by adding a check to see if the selector is array-like in .not() before... 
X-Git-Tag: 1.2.2b2~19
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=90b25efa6c3c3676c5ae1dd782d04726e03a31e8;p=jquery.git

Fixed #2062 by adding a check to see if the selector is array-like in .not() before testing it as an array.  Otherwise it does a straight comparison during the filter test.
---

diff --git a/src/core.js b/src/core.js
index c7f30d6de..1ec8de057 100644
--- a/src/core.js
+++ b/src/core.js
@@ -353,7 +353,10 @@ jQuery.fn = jQuery.prototype = {
 				selector = jQuery.multiFilter( selector, this );
 
 		return this.filter(function() {
-			return jQuery.inArray( this, selector ) < 0;
+			// check to see if the selector is array-like otherwise assume it is just a DOM element
+			return ( selector.length && selector[selector.length - 1] !== undefined )
+				? jQuery.inArray( this, selector ) < 0
+				: this != selector;
 		});
 	},
 
diff --git a/test/unit/core.js b/test/unit/core.js
index 088726ff7..ea687c8f8 100644
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -1058,11 +1058,13 @@ test("filter()", function() {
 });
 
 test("not()", function() {
-	expect(5);
+	expect(7);
 	ok( $("#main > p#ap > a").not("#google").length == 2, "not('selector')" );
+	ok( $("#main > p#ap > a").not(document.getElementById("google")).length == 2, "not(DOMElement)" );
 	isSet( $("p").not(".result").get(), q("firstp", "ap", "sndp", "en", "sap", "first"), "not('.class')" );
 	isSet( $("p").not("#ap, #sndp, .result").get(), q("firstp", "en", "sap", "first"), "not('selector, selector')" );
 	isSet( $("p").not($("#ap, #sndp, .result")).get(), q("firstp", "en", "sap", "first"), "not(jQuery)" );
+	ok( $("p").not(document.getElementsByTagName("p")).length == 0, "not(Array-like DOM collection)" );
 	isSet( $("#form option").not("option.emptyopt:contains('Nothing'),[selected],[value='1']").get(), q("option1c", "option1d", "option2c", "option3d" ), "not('complex selector')");
 });