From: Eric Davis <edavis@littlestreamsoftware.com>
Date: Thu, 11 Feb 2010 16:42:52 +0000 (+0000)
Subject: Refactored IssueStatus finder to a before_filter
X-Git-Tag: 1.0.0~368
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=937d0c70f770912de8637798cded5071149876c0;p=redmine.git

Refactored IssueStatus finder to a before_filter

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3410 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb
index 19eee5fba..4b7942a7c 100644
--- a/app/controllers/reports_controller.rb
+++ b/app/controllers/reports_controller.rb
@@ -17,11 +17,9 @@
 
 class ReportsController < ApplicationController
   menu_item :issues
-  before_filter :find_project, :authorize
+  before_filter :find_project, :authorize, :find_issue_statuses
 
   def issue_report
-    @statuses = IssueStatus.find(:all, :order => 'position')
-    
     @trackers = @project.trackers
     @versions = @project.shared_versions.sort
     @priorities = IssuePriority.all
@@ -42,8 +40,6 @@ class ReportsController < ApplicationController
   end  
 
   def issue_report_details
-    @statuses = IssueStatus.find(:all, :order => 'position')
-
     case params[:detail]
     when "tracker"
       @field = "tracker_id"
@@ -91,4 +87,9 @@ class ReportsController < ApplicationController
     end
   end
 
+  private
+
+  def find_issue_statuses
+    @statuses = IssueStatus.find(:all, :order => 'position')
+  end
 end