From: Olivier Lamy Date: Tue, 14 Jun 2011 08:49:51 +0000 (+0000) Subject: use StringBuilder rather than + in a loop X-Git-Tag: archiva-1.4-M1~646 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9b167a09343962730cfe305e5eea5b497cf5a42e;p=archiva.git use StringBuilder rather than + in a loop git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1135411 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/archiva-modules/archiva-base/archiva-policies/src/main/java/org/apache/maven/archiva/policies/ProxyDownloadException.java b/archiva-modules/archiva-base/archiva-policies/src/main/java/org/apache/maven/archiva/policies/ProxyDownloadException.java index 9d328c6b7..845df4ecb 100644 --- a/archiva-modules/archiva-base/archiva-policies/src/main/java/org/apache/maven/archiva/policies/ProxyDownloadException.java +++ b/archiva-modules/archiva-base/archiva-policies/src/main/java/org/apache/maven/archiva/policies/ProxyDownloadException.java @@ -51,15 +51,15 @@ public class ProxyDownloadException private static String constructMessage( String message, Map failures ) { - String msg = message + ":"; + StringBuilder msg = new StringBuilder( message + ":" ); for ( Map.Entry entry : failures.entrySet() ) { - msg += "\n\t" + entry.getKey() + ": " + entry.getValue().getMessage(); + msg.append( "\n\t" ).append( entry.getKey() ).append( ": " ).append( entry.getValue().getMessage() ); } - return msg; + return msg.toString(); } - public Map getFailures() + public Map getFailures() { return failures; }