From: Artur Signell <artur.signell@itmill.com>
Date: Tue, 11 Aug 2009 14:55:31 +0000 (+0000)
Subject: Test case and fix for #3199
X-Git-Tag: 6.7.0.beta1~2624
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9c34ae76e993311ffbbd4c6e5394d32b6b615b23;p=vaadin-framework.git

Test case and fix for #3199

svn changeset:8462/svn branch:6.1
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VTabsheet.java b/src/com/vaadin/terminal/gwt/client/ui/VTabsheet.java
index da965c15dc..5c9dfc7dd0 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VTabsheet.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VTabsheet.java
@@ -616,8 +616,8 @@ public class VTabsheet extends VTabsheetBase {
         updateOpenTabSize();
         VTabsheet.this.removeStyleDependentName("loading");
         if (previousVisibleWidget != null) {
-            DOM.setStyleAttribute(previousVisibleWidget.getElement(),
-                    "visibility", "");
+            DOM.setStyleAttribute(DOM.getParent(previousVisibleWidget
+                    .getElement()), "visibility", "");
             previousVisibleWidget = null;
         }
     }
diff --git a/src/com/vaadin/tests/components/tabsheet/PreventTabChange.java b/src/com/vaadin/tests/components/tabsheet/PreventTabChange.java
new file mode 100644
index 0000000000..01f0b841f8
--- /dev/null
+++ b/src/com/vaadin/tests/components/tabsheet/PreventTabChange.java
@@ -0,0 +1,67 @@
+package com.vaadin.tests.components.tabsheet;
+
+import com.vaadin.tests.components.TestBase;
+import com.vaadin.ui.Component;
+import com.vaadin.ui.Label;
+import com.vaadin.ui.TabSheet;
+import com.vaadin.ui.TabSheet.SelectedTabChangeEvent;
+import com.vaadin.ui.TabSheet.SelectedTabChangeListener;
+
+public class PreventTabChange extends TestBase implements
+        SelectedTabChangeListener {
+
+    private TabSheet tabSheet;
+
+    private Component lastTab;
+
+    private Label tab1;
+    private Label tab2;
+    private Label tab3;
+
+    @Override
+    protected String getDescription() {
+        return "Tests prevention of selecting certain tabs. Selecting the tabs in order (1-2-3-1) should work, while selecting out of order should cause the current tab to remain selected. The selected tab will actually first be changed (by the client) and then changed back (on the server response).";
+    }
+
+    @Override
+    protected Integer getTicketNumber() {
+        return null;
+    }
+
+    @Override
+    protected void setup() {
+        tabSheet = new TabSheet();
+        tabSheet.addListener(this);
+        tab1 = new Label("Tab 1 contents");
+        tab2 = new Label("Tab 2 contents");
+        tab3 = new Label("Tab 3 contents");
+
+        tabSheet.addTab(tab1, "The first tab", null);
+        tabSheet.addTab(tab2, "The second tab", null);
+        tabSheet.addTab(tab3, "The third tab", null);
+
+        lastTab = tab1;
+        tabSheet.setSelectedTab(tab1);
+
+        addComponent(tabSheet);
+    }
+
+    public void selectedTabChange(SelectedTabChangeEvent event) {
+
+        TabSheet tabsheet = event.getTabSheet();
+        if (lastTab == tab1) {
+            if (tabsheet.getSelectedTab() != tab2) {
+                tabsheet.setSelectedTab(lastTab);
+            }
+        } else if (lastTab == tab2) {
+            if (tabsheet.getSelectedTab() != tab3) {
+                tabsheet.setSelectedTab(lastTab);
+            }
+        } else if (lastTab == tab3) {
+            if (tabsheet.getSelectedTab() != tab1) {
+                tabsheet.setSelectedTab(lastTab);
+            }
+        }
+        lastTab = tabsheet.getSelectedTab();
+    }
+}