From: Javen O'Neal Date: Sat, 11 Jun 2016 11:40:30 +0000 (+0000) Subject: bug 57840: lazily compute hashCode; patch from Greg Woolsey X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9e54ef68cb649b532f15c7b3c074f95150552f98;p=poi.git bug 57840: lazily compute hashCode; patch from Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java index 22e1449db1..a0cd24d450 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFEvaluationSheet.java @@ -62,16 +62,18 @@ final class XSSFEvaluationSheet implements EvaluationSheet { private static class CellKey { private final int _row; private final int _col; - private final int _hash; + private int _hash = -1; //lazily computed protected CellKey(int row, int col) { _row = row; _col = col; - _hash = (17 * 37 + row) * 37 + col; } @Override public int hashCode() { + if ( _hash == -1 ) { + _hash = (17 * 37 + _row) * 37 + _col; + } return _hash; }