From: Marko Grönroos <magi@iki.fi>
Date: Tue, 11 Dec 2007 12:23:56 +0000 (+0000)
Subject: Fixes #1213 in another way. Remove indicator element altogether.
X-Git-Tag: 6.7.0.beta1~5248
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9e64a503ad65868bd0227704f84302cc196bd1f7;p=vaadin-framework.git

Fixes #1213 in another way. Remove indicator element altogether.

svn changeset:3214/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/Caption.java b/src/com/itmill/toolkit/terminal/gwt/client/Caption.java
index f5ba082f73..06d502696f 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/Caption.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/Caption.java
@@ -46,9 +46,6 @@ public class Caption extends HTML {
                 DOM.setElementProperty(errorIndicatorElement, "className",
                         "i-errorindicator");
                 DOM.insertChild(getElement(), errorIndicatorElement, 0);
-            } else {
-                // Restore the indicator that was previously made invisible 
-                DOM.setStyleAttribute(errorIndicatorElement, "display", "inline");
             }
             if (errorMessage == null) {
                 errorMessage = new ErrorMessage();
@@ -56,8 +53,8 @@ public class Caption extends HTML {
             errorMessage.updateFromUIDL(errorUidl);
 
         } else if (errorIndicatorElement != null) {
-            // Just make the error indicator element invisible
-            DOM.setStyleAttribute(errorIndicatorElement, "display", "none");
+            DOM.removeChild(getElement(), errorIndicatorElement);
+            errorIndicatorElement = null;
         }
 
         if (uidl.hasAttribute("icon")) {