From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Fri, 4 May 2012 16:57:15 +0000 (+0000)
Subject: Fixed undefined method `<=>' for nil:NilClass when sorting repositories with nil... 
X-Git-Tag: 2.0.0~63
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9f396a6dfbb93231a085ee4111ff9f9f7b769fe9;p=redmine.git

Fixed undefined method `<=>' for nil:NilClass when sorting repositories with nil identifiers (#10827).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9619 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/repository.rb b/app/models/repository.rb
index b0bf0d2a7..59110fd4d 100644
--- a/app/models/repository.rb
+++ b/app/models/repository.rb
@@ -119,7 +119,7 @@ class Repository < ActiveRecord::Base
     elsif repository.is_default?
       1
     else
-      identifier <=> repository.identifier
+      identifier.to_s <=> repository.identifier.to_s
     end
   end
 
diff --git a/test/unit/repository_test.rb b/test/unit/repository_test.rb
index 1fe246d8e..466babb38 100644
--- a/test/unit/repository_test.rb
+++ b/test/unit/repository_test.rb
@@ -318,4 +318,13 @@ class RepositoryTest < ActiveSupport::TestCase
     assert_equal "test_value_23",
                  repo.extra_info["test_2"]["test_23"]
   end
+
+  def test_sort_should_not_raise_an_error_with_nil_identifiers
+    r1 = Repository.new
+    r2 = Repository.new
+
+    assert_nothing_raised do
+      [r1, r2].sort
+    end
+  end
 end