From: Alexander Kriegisch <Alexander@Kriegisch.name>
Date: Mon, 9 Jan 2023 16:59:20 +0000 (+0100)
Subject: Simplify if-else in WildTypePattern.matchesExactlyByName
X-Git-Tag: V1_9_20~55
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a0bcb6ba4b4b81eef4fc95d949cd81538b17aa8f;p=aspectj.git

Simplify if-else in WildTypePattern.matchesExactlyByName

A simple boolean condition is enough.

Loosely relates to https://github.com/eclipse/org.aspectj/issues/24, but
actually it is just drive-by cosmetics.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
---

diff --git a/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/WildTypePattern.java b/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/WildTypePattern.java
index 9c6a62a5f..37653a9cc 100644
--- a/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/WildTypePattern.java
+++ b/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/WildTypePattern.java
@@ -326,11 +326,7 @@ public class WildTypePattern extends TypePattern {
 					numDimensionsInTargetType++;
 					targetTypeName = targetTypeName.substring(index + 1);
 				}
-				if (numDimensionsInTargetType == dim) {
-					return true;
-				} else {
-					return false;
-				}
+        return numDimensionsInTargetType == dim;
 			}
 		}