From: Lukas Reschke <lukas@statuscode.ch>
Date: Sat, 19 Jul 2014 08:17:24 +0000 (+0200)
Subject: Remove uneeded `strip_tags`
X-Git-Tag: v7.0.1RC1~4^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a393670f7d4bf6cc31356e0023554133266a823d;p=nextcloud-server.git

Remove uneeded `strip_tags`

This `strip_tags` seems to be completely unneeded and will cause problems with passwords containing stripped characters. (e.g. `<` or `>`)

Needs https://github.com/owncloud/core/pull/9735 to be merged first.
---

diff --git a/lib/base.php b/lib/base.php
index 24381611001..730cee5231d 100644
--- a/lib/base.php
+++ b/lib/base.php
@@ -807,8 +807,8 @@ class OC {
 		foreach ($vars as $var) {
 			if (isset($_SERVER[$var]) && preg_match('/Basic\s+(.*)$/i', $_SERVER[$var], $matches)) {
 				list($name, $password) = explode(':', base64_decode($matches[1]), 2);
-				$_SERVER['PHP_AUTH_USER'] = strip_tags($name);
-				$_SERVER['PHP_AUTH_PW'] = strip_tags($password);
+				$_SERVER['PHP_AUTH_USER'] = $name;
+				$_SERVER['PHP_AUTH_PW'] = $password;
 				break;
 			}
 		}