From: Leif Åstrand <leif@vaadin.com>
Date: Thu, 1 Mar 2012 08:39:49 +0000 (+0200)
Subject: Use absolute positioning to avoid a scrollbar bug (#8313)
X-Git-Tag: 7.0.0.alpha2~411
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a64a72058e6506025285ab69bb2409c7645cb696;p=vaadin-framework.git

Use absolute positioning to avoid a scrollbar bug (#8313)
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/RootConnector.java b/src/com/vaadin/terminal/gwt/client/ui/RootConnector.java
index fd49fb1cb2..a42b797af8 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/RootConnector.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/RootConnector.java
@@ -8,6 +8,8 @@ import java.util.Iterator;
 
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.dom.client.Style;
+import com.google.gwt.dom.client.Style.Position;
 import com.google.gwt.event.dom.client.DomEvent.Type;
 import com.google.gwt.event.shared.EventHandler;
 import com.google.gwt.event.shared.HandlerRegistration;
@@ -27,7 +29,8 @@ import com.vaadin.terminal.gwt.client.UIDL;
 import com.vaadin.terminal.gwt.client.Util;
 import com.vaadin.terminal.gwt.client.VConsole;
 
-public class RootConnector extends AbstractComponentContainerConnector {
+public class RootConnector extends AbstractComponentContainerConnector
+        implements SimpleManagedLayout {
 
     private static final String CLICK_EVENT_IDENTIFIER = PanelConnector.CLICK_EVENT_IDENTIFIER;
 
@@ -221,8 +224,6 @@ public class RootConnector extends AbstractComponentContainerConnector {
             Window.addResizeHandler(getWidget());
         }
 
-        getWidget().onResize();
-
         // finally set scroll position from UIDL
         if (uidl.hasVariable("scrollTop")) {
             getWidget().scrollable = true;
@@ -316,4 +317,21 @@ public class RootConnector extends AbstractComponentContainerConnector {
         return GWT.create(VView.class);
     }
 
+    public void layout() {
+        ComponentConnector child = getWidget().layout;
+        Style childStyle = child.getWidget().getElement().getStyle();
+        /*
+         * Must set absolute position if the child has relative height and
+         * there's a chance of horizontal scrolling as some browsers will
+         * otherwise not take the scrollbar into account when calculating the
+         * height. Assuming v-view does not have an undefined width for now, see
+         * #8460.
+         */
+        if (child.isRelativeHeight()) {
+            childStyle.setPosition(Position.ABSOLUTE);
+        } else {
+            childStyle.clearPosition();
+        }
+    }
+
 }