From: Aurelien Poscia <aurelien.poscia@sonarsource.com>
Date: Thu, 12 Jan 2023 09:45:29 +0000 (+0100)
Subject: SONAR-12243 Do not require 'commit statuses' GitHub App permission
X-Git-Tag: 9.9.0.65466~41
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a6ba3ff821bbc2d5ed79f3bea5e78bd257c0cb37;p=sonarqube.git

SONAR-12243 Do not require 'commit statuses' GitHub App permission
---

diff --git a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationClientImpl.java b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationClientImpl.java
index 3ac26c2d00b..eb7a4718a34 100644
--- a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationClientImpl.java
+++ b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationClientImpl.java
@@ -100,7 +100,6 @@ public class GithubApplicationClientImpl implements GithubApplicationClient {
     Map<String, String> permissions = new HashMap<>();
     permissions.put("checks", WRITE_PERMISSION_NAME);
     permissions.put("pull_requests", WRITE_PERMISSION_NAME);
-    permissions.put("statuses", READ_PERMISSION_NAME);
     permissions.put("metadata", READ_PERMISSION_NAME);
 
     String endPoint = "/app";
diff --git a/server/sonar-alm-client/src/test/java/org/sonar/alm/client/github/GithubApplicationClientImplTest.java b/server/sonar-alm-client/src/test/java/org/sonar/alm/client/github/GithubApplicationClientImplTest.java
index fccb783fffd..ed823e73d4b 100644
--- a/server/sonar-alm-client/src/test/java/org/sonar/alm/client/github/GithubApplicationClientImplTest.java
+++ b/server/sonar-alm-client/src/test/java/org/sonar/alm/client/github/GithubApplicationClientImplTest.java
@@ -163,7 +163,6 @@ public class GithubApplicationClientImplTest {
       + "      \"permissions\": {\n"
       + "        \"checks\": \"read\",\n"
       + "        \"metadata\": \"read\",\n"
-      + "        \"statuses\": \"read\",\n"
       + "        \"pull_requests\": \"read\"\n"
       + "      }\n"
       + "}";
@@ -183,7 +182,6 @@ public class GithubApplicationClientImplTest {
       + "      \"permissions\": {\n"
       + "        \"checks\": \"write\",\n"
       + "        \"metadata\": \"read\",\n"
-      + "        \"statuses\": \"read\",\n"
       + "        \"pull_requests\": \"write\"\n"
       + "      }\n"
       + "}";