From: Julien Lancelot <julien.lancelot@sonarsource.com>
Date: Mon, 17 Mar 2014 11:45:17 +0000 (+0100)
Subject: SONAR-5056 Do nothing hen rule has no default characteristic or overridden characteristic
X-Git-Tag: 4.3~405
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=aa14b022e5eb4a029f72d9307535d69b9f2fb41d;p=sonarqube.git

SONAR-5056 Do nothing hen rule has no default characteristic or overridden characteristic
---

diff --git a/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java b/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java
index 0b2332bc4fc..5732f129663 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java
@@ -79,7 +79,7 @@ public class RulesProvider extends ProviderAdapter {
         .setStatus(RuleStatus.valueOf(ruleDto.getStatus()));
       // TODO should we set metadata ?
 
-      if (!ruleDto.isCharacteristicDisabled()) {
+      if (ruleDto.hasCharacteristic()) {
         newRule.setCharacteristic(characteristic(ruleDto, ruleKey, debtModel).key());
         setFunction(ruleDto, newRule, ruleKey, durations);
       }
diff --git a/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java b/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java
index d0a8b978db3..b6b280cf96b 100644
--- a/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java
+++ b/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java
@@ -314,8 +314,8 @@ public final class RuleDto {
     return this;
   }
 
-  public boolean isCharacteristicDisabled(){
-    return DISABLED_CHARACTERISTIC_ID.equals(characteristicId);
+  public boolean hasCharacteristic(){
+    return (characteristicId != null && !DISABLED_CHARACTERISTIC_ID.equals(characteristicId)) || defaultCharacteristicId != null;
   }
 
   @Override