From: fenn-cs <fenn25.fn@gmail.com>
Date: Wed, 6 Dec 2023 15:03:27 +0000 (+0100)
Subject: Correct semantics for link opening in global search
X-Git-Tag: v29.0.0beta1~695^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=aa25590130ad6fcee7a3244848d0c8612108a889;p=nextcloud-server.git

Correct semantics for link opening in global search

Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : https://github.com/nextcloud-libraries/nextcloud-vue/pull/4923

Resolves :  #41800

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
---

diff --git a/core/src/components/GlobalSearch/SearchResult.vue b/core/src/components/GlobalSearch/SearchResult.vue
index a35395922d1..a746a5751b7 100644
--- a/core/src/components/GlobalSearch/SearchResult.vue
+++ b/core/src/components/GlobalSearch/SearchResult.vue
@@ -2,7 +2,8 @@
 	<NcListItem class="result-items__item"
 		:name="title"
 		:bold="false"
-		@click="openResult(resourceUrl)">
+		:href="resourceUrl"
+		target="_self">
 		<template #icon>
 			<div aria-hidden="true"
 				class="result-items__item-icon"
@@ -91,11 +92,6 @@ export default {
 		thumbnailErrorHandler() {
 			this.thumbnailHasError = true
 		},
-		openResult(url) {
-			if (url) {
-				window.location = url
-			}
-		},
 	},
 }
 </script>