From: Joas Schilling <coding@schilljs.com>
Date: Fri, 28 Aug 2020 06:57:06 +0000 (+0200)
Subject: Don't use SELECT DISTINCT when to_char() is used in a WHERE statement
X-Git-Tag: v20.0.0beta4~40^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=aa5e4aacc1c7a8ec318454298bbbd11e44b33962;p=nextcloud-server.git

Don't use SELECT DISTINCT when to_char() is used in a WHERE statement

Nice bug in Oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>
---

diff --git a/apps/workflowengine/lib/Manager.php b/apps/workflowengine/lib/Manager.php
index b583b190070..fefeb9230e6 100644
--- a/apps/workflowengine/lib/Manager.php
+++ b/apps/workflowengine/lib/Manager.php
@@ -147,10 +147,10 @@ class Manager implements IManager {
 	public function getAllConfiguredEvents() {
 		$query = $this->connection->getQueryBuilder();
 
-		$query->selectDistinct('class')
-			->addSelect('entity', 'events')
+		$query->select('class', 'entity', $query->expr()->castColumn('events', IQueryBuilder::PARAM_STR))
 			->from('flow_operations')
-			->where($query->expr()->neq('events', $query->createNamedParameter('[]'), IQueryBuilder::PARAM_STR));
+			->where($query->expr()->neq('events', $query->createNamedParameter('[]'), IQueryBuilder::PARAM_STR))
+			->groupBy('class', 'entity', $query->expr()->castColumn('events', IQueryBuilder::PARAM_STR));
 
 		$result = $query->execute();
 		$operations = [];