From: Jeremy Davis <jeremy.davis@sonarsource.com>
Date: Tue, 5 Dec 2023 15:00:56 +0000 (+0100)
Subject: SONAR-21104 Allow scrolling for rule activation modal
X-Git-Tag: 10.4.0.87286~356
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=acb6b2e854f7538692b28b0cf92d70cc62404399;p=sonarqube.git

SONAR-21104 Allow scrolling for rule activation modal
---

diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/ActivationFormModal.tsx b/server/sonar-web/src/main/js/apps/coding-rules/components/ActivationFormModal.tsx
index 01771fdf72a..048795a0195 100644
--- a/server/sonar-web/src/main/js/apps/coding-rules/components/ActivationFormModal.tsx
+++ b/server/sonar-web/src/main/js/apps/coding-rules/components/ActivationFormModal.tsx
@@ -92,12 +92,15 @@ export default function ActivationFormModal(props: Readonly<Props>) {
     setParams({ ...params, [name]: value });
   };
 
+  const makeScrollable = (rule.params?.length ?? 0) > 1;
+
   return (
     <Modal
       headerTitle={modalHeader}
       onClose={props.onClose}
       loading={submitting}
-      isOverflowVisible
+      isOverflowVisible={!makeScrollable}
+      isScrollable={makeScrollable}
       primaryButton={
         <ButtonPrimary disabled={submitting || activeInAllProfiles} form={FORM_ID} type="submit">
           {isUpdateMode ? translate('save') : translate('coding_rules.activate')}
@@ -105,7 +108,7 @@ export default function ActivationFormModal(props: Readonly<Props>) {
       }
       secondaryButtonLabel={translate('cancel')}
       body={
-        <form id={FORM_ID} onSubmit={handleFormSubmit}>
+        <form className="sw-pb-10" id={FORM_ID} onSubmit={handleFormSubmit}>
           {!isUpdateMode && activeInAllProfiles && (
             <FlagMessage className="sw-mb-2" variant="info">
               {translate('coding_rules.active_in_all_profiles')}