From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Mon, 16 Jul 2012 08:06:09 +0000 (+0200)
Subject: Complete unit tests of SettingsChangeNotifier
X-Git-Tag: 3.2~71
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ae188de58fce73224487e5626641376d8d702b9a;p=sonarqube.git

Complete unit tests of SettingsChangeNotifier
---

diff --git a/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java b/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
index 3cbeaa2168b..8aef53371a8 100644
--- a/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
+++ b/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
@@ -19,6 +19,7 @@
  */
 package org.sonar.server.platform;
 
+import com.google.common.annotations.VisibleForTesting;
 import org.sonar.api.ServerComponent;
 import org.sonar.api.config.GlobalPropertyChangeHandler;
 
@@ -26,7 +27,8 @@ import javax.annotation.Nullable;
 
 public class SettingsChangeNotifier implements ServerComponent {
 
-  private GlobalPropertyChangeHandler[] changeHandlers;
+  @VisibleForTesting
+  GlobalPropertyChangeHandler[] changeHandlers;
 
   public SettingsChangeNotifier(GlobalPropertyChangeHandler[] changeHandlers) {
     this.changeHandlers = changeHandlers;
diff --git a/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java b/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
index d064745c04a..05755d6661d 100644
--- a/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
+++ b/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
@@ -24,6 +24,7 @@ import org.hamcrest.Description;
 import org.junit.Test;
 import org.sonar.api.config.GlobalPropertyChangeHandler;
 
+import static org.fest.assertions.Assertions.assertThat;
 import static org.mockito.Matchers.argThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
@@ -46,4 +47,14 @@ public class SettingsChangeNotifierTest {
       }
     }));
   }
+
+  @Test
+  public void no_handlers() {
+    SettingsChangeNotifier notifier = new SettingsChangeNotifier();
+
+    assertThat(notifier.changeHandlers).isEmpty();
+
+    // does not fail
+    notifier.onGlobalPropertyChange("foo", "bar");
+  }
 }