From: Alexander Moisseev <moiseev@mezonplus.ru>
Date: Sun, 15 Jul 2018 10:26:53 +0000 (+0300)
Subject: [Minor] Do not use identifiers before their declarations
X-Git-Tag: 1.7.9~119^2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ae91f7edb4a528d4a2ac53194b941b69ebfd0e2b;p=rspamd.git

[Minor] Do not use identifiers before their declarations
---

diff --git a/.eslintrc.json b/.eslintrc.json
index b4f242a41..f72a23118 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -74,7 +74,6 @@
         "no-loop-func": "off",
         "no-negated-condition": "off",
         "no-underscore-dangle": "off",
-        "no-use-before-define": "off",
         "one-var-declaration-per-line": "off",
         "prefer-spread": "off",
         "sort-keys": "off",
diff --git a/interface/js/app/history.js b/interface/js/app/history.js
index 8e34dff24..b1097528c 100644
--- a/interface/js/app/history.js
+++ b/interface/js/app/history.js
@@ -556,7 +556,7 @@ define(["jquery", "footable", "humanize"],
 
             if (checked_server === "All SERVERS") {
                 rspamd.queryNeighbours("history", function (req_data) {
-                    function differentVersions() {
+                    function differentVersions(neighbours_data) {
                         var dv = neighbours_data.some(function (e) {
                             return e.version !== neighbours_data[0].version;
                         });
@@ -570,7 +570,7 @@ define(["jquery", "footable", "humanize"],
                     var neighbours_data = req_data
                         .filter(function (d) { return d.status; }) // filter out unavailable neighbours
                         .map(function (d) { return d.data; });
-                    if (neighbours_data.length && !differentVersions()) {
+                    if (neighbours_data.length && !differentVersions(neighbours_data)) {
                         var data = {};
                         if (neighbours_data[0].version) {
                             data.rows = [].concat.apply([], neighbours_data
diff --git a/interface/js/app/rspamd.js b/interface/js/app/rspamd.js
index b5d44b9f9..03a02c42b 100644
--- a/interface/js/app/rspamd.js
+++ b/interface/js/app/rspamd.js
@@ -42,6 +42,16 @@ function ($, d3pie, visibility, tab_stat, tab_graph, tab_config,
     var timer_id = [];
     var selData; // Graph's dataset selector state
 
+    function cleanCredentials() {
+        sessionStorage.clear();
+        $("#statWidgets").empty();
+        $("#listMaps").empty();
+        $("#modalBody").empty();
+        $("#historyLog tbody").remove();
+        $("#errorsLog tbody").remove();
+        $("#symbolsTable tbody").remove();
+    }
+
     function stopTimers() {
         for (var key in timer_id) {
             Visibility.stop(timer_id[key]);
@@ -140,17 +150,6 @@ function ($, d3pie, visibility, tab_stat, tab_graph, tab_config,
         sessionStorage.setItem("Password", password);
     }
 
-    // @clean credentials
-    function cleanCredentials() {
-        sessionStorage.clear();
-        $("#statWidgets").empty();
-        $("#listMaps").empty();
-        $("#modalBody").empty();
-        $("#historyLog tbody").remove();
-        $("#errorsLog tbody").remove();
-        $("#symbolsTable tbody").remove();
-    }
-
     function isLogged() {
         if (sessionStorage.getItem("Credentials") !== null) {
             return true;