From: Pierre Ossman <ossman@cendio.se>
Date: Fri, 6 Sep 2024 14:30:02 +0000 (+0200)
Subject: Move recent server to top of history
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=af29133e1d0b97e1e3699224920043b8195be577;p=tigervnc.git

Move recent server to top of history

It's easier for the user if the most recently used entries are at the
top.
---

diff --git a/vncviewer/ServerDialog.cxx b/vncviewer/ServerDialog.cxx
index c5db8e1a..d1d4bdf8 100644
--- a/vncviewer/ServerDialog.cxx
+++ b/vncviewer/ServerDialog.cxx
@@ -292,13 +292,12 @@ void ServerDialog::handleConnect(Fl_Widget* /*widget*/, void *data)
              e.str());
   }
 
+  // avoid duplicates in the history
+  dialog->serverHistory.remove(servername);
+  dialog->serverHistory.insert(dialog->serverHistory.begin(), servername);
+
   try {
-    list<string>::iterator elem = std::find(dialog->serverHistory.begin(), dialog->serverHistory.end(), servername);
-    // avoid duplicates in the history
-    if(dialog->serverHistory.end() == elem) {
-      dialog->serverHistory.insert(dialog->serverHistory.begin(), servername);
-      dialog->saveServerHistory();
-    }
+    dialog->saveServerHistory();
   } catch (Exception& e) {
     vlog.error("%s", e.str());
     fl_alert(_("Unable to save the server history:\n\n%s"),