From: Go MAEDA <maeda@farend.jp>
Date: Thu, 3 Oct 2024 22:36:56 +0000 (+0000)
Subject: Replace `for` loops with `forEach` in `buildFilterRow` function (#32523).
X-Git-Tag: 6.0.0~100
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b135db09161047c7b18e2be5332e89eaa4f5ecc5;p=redmine.git

Replace `for` loops with `forEach` in `buildFilterRow` function (#32523).

Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@23102 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 8226f0f69..82adf53a8 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -185,7 +185,7 @@ function buildFilterRow(field, operator, values) {
   if (!filterOptions) return;
   var operators = operatorByType[filterOptions['type']];
   var filterValues = filterOptions['values'];
-  var i, select;
+  var select;
 
   var tr = $('<div class="filter">').attr('id', 'tr_'+fieldId).html(
     '<div class="field"><input checked="checked" id="cb_'+fieldId+'" name="f[]" value="'+field+'" type="checkbox"><label for="cb_'+fieldId+'"> '+filterOptions['name']+'</label></div>' +
@@ -195,11 +195,11 @@ function buildFilterRow(field, operator, values) {
   filterTable.append(tr);
 
   select = tr.find('.operator select');
-  for (i = 0; i < operators.length; i++) {
-    var option = $('<option>').val(operators[i]).text(operatorLabels[operators[i]]);
-    if (operators[i] == operator) { option.prop('selected', true); }
+  operators.forEach(function(op) {
+    var option = $('<option>').val(op).text(operatorLabels[op]);
+    if (op == operator) { option.prop('selected', true); }
     select.append(option);
-  }
+  });
   select.change(function(){ toggleOperator(field); });
 
   switch (filterOptions['type']) {
@@ -215,8 +215,7 @@ function buildFilterRow(field, operator, values) {
     );
     select = tr.find('.values select');
     if (values.length > 1) { select.attr('multiple', true); }
-    for (i = 0; i < filterValues.length; i++) {
-      var filterValue = filterValues[i];
+    filterValues.forEach(function(filterValue) {
       var option = $('<option>');
       if ($.isArray(filterValue)) {
         option.val(filterValue[1]).text(filterValue[0]);
@@ -231,7 +230,7 @@ function buildFilterRow(field, operator, values) {
         if ($.inArray(filterValue, values) > -1) {option.prop('selected', true);}
       }
       select.append(option);
-    }
+    });
     break;
   case "date":
   case "date_past":
@@ -259,13 +258,12 @@ function buildFilterRow(field, operator, values) {
     );
     $('#values_'+fieldId).val(values[0]);
     select = tr.find('.values select');
-    for (i = 0; i < filterValues.length; i++) {
-      var filterValue = filterValues[i];
+    filterValues.forEach(function(filterValue) {
       var option = $('<option>');
       option.val(filterValue[1]).text(filterValue[0]);
       if (values[0] == filterValue[1]) { option.prop('selected', true); }
       select.append(option);
-    }
+    });
     break;
   case "integer":
   case "float":