From: Olivier Lamy <olamy@apache.org>
Date: Tue, 12 Feb 2013 17:13:23 +0000 (+0000)
Subject: ensure correct default values for archiva model
X-Git-Tag: archiva-1.4-M4~205
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b2130aacec79fd0eecacc84bcb9e4edc5a31c2a2;p=archiva.git

ensure correct default values for archiva model

git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1445274 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/archiva-modules/archiva-base/archiva-configuration/src/main/java/org/apache/archiva/configuration/DefaultArchivaConfiguration.java b/archiva-modules/archiva-base/archiva-configuration/src/main/java/org/apache/archiva/configuration/DefaultArchivaConfiguration.java
index 000386126..2f5f439fc 100644
--- a/archiva-modules/archiva-base/archiva-configuration/src/main/java/org/apache/archiva/configuration/DefaultArchivaConfiguration.java
+++ b/archiva-modules/archiva-base/archiva-configuration/src/main/java/org/apache/archiva/configuration/DefaultArchivaConfiguration.java
@@ -719,7 +719,7 @@ public class DefaultArchivaConfiguration
 
         List<String> dbConsumers = Arrays.asList( "update-db-artifact", "update-db-repository-metadata" );
 
-        // remove database consumers  if here
+        // remove database consumers if here
         List<String> intersec =
             ListUtils.intersection( dbConsumers, configuration.getRepositoryScanning().getKnownContentConsumers() );
 
diff --git a/archiva-modules/archiva-base/archiva-configuration/src/main/mdo/configuration.mdo b/archiva-modules/archiva-base/archiva-configuration/src/main/mdo/configuration.mdo
index b1257abb1..cabb59331 100644
--- a/archiva-modules/archiva-base/archiva-configuration/src/main/mdo/configuration.mdo
+++ b/archiva-modules/archiva-base/archiva-configuration/src/main/mdo/configuration.mdo
@@ -1564,6 +1564,7 @@
           <description>ssl LDAP connection.</description>
           <version>1.4.0+</version>
           <type>boolean</type>
+          <defaultValue>false</defaultValue>
         </field>
         <field>
           <name>baseDn</name>
@@ -1606,12 +1607,14 @@
           <description>The LDAP authenticator enabled.</description>
           <version>1.4.0+</version>
           <type>boolean</type>
+          <defaultValue>false</defaultValue>
         </field>
         <field>
           <name>writable</name>
           <description>LDAP writable.</description>
           <version>1.4.0+</version>
           <type>boolean</type>
+          <defaultValue>false</defaultValue>
         </field>
         <field>
           <name>extraProperties</name>
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/archiva/general-admin.js b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/archiva/general-admin.js
index b2e59166e..153f737df 100644
--- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/archiva/general-admin.js
+++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/archiva/general-admin.js
@@ -1637,7 +1637,7 @@ define("archiva.general-admin",["jquery","i18n","utils","jquery.tmpl","knockout"
           $.ajax("restServices/redbackServices/ldapGroupMappingService/ldapGroups", {
             type: "GET",
             dataType: 'json',
-            success: function(data) {
+            complete: function(data) {
               var groups = [];
               if(data&&data.strings){
                 groups = $.isArray(data.strings)? $.map(data.strings,function(item){
diff --git a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/templates/archiva/general-admin.html b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/templates/archiva/general-admin.html
index af6d25d88..99abc49b7 100644
--- a/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/templates/archiva/general-admin.html
+++ b/archiva-modules/archiva-web/archiva-webapp/src/main/webapp/js/templates/archiva/general-admin.html
@@ -1029,7 +1029,7 @@
                 ${$.i18n.prop('redback.runtime.ldap.writable.label')}
               </label>
               <div class="controls">
-                <input type="checkbox" id="ldap-writable" name="ldap-ssl"
+                <input type="checkbox" id="ldap-writable" name="ldap-writable"
                        data-bind="checked: redbackRuntimeConfiguration().ldapConfiguration().writable"/>
               </div>
             </div>