From: Vincent Petry <pvince81@owncloud.com>
Date: Thu, 9 Oct 2014 12:58:53 +0000 (+0200)
Subject: Log warning when no uid was found for user
X-Git-Tag: v7.0.3RC1~19
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b297ddf349330a174804ea3899601cbdea224d93;p=nextcloud-server.git

Log warning when no uid was found for user

In some incomplete setups (like mine) it can happen that the uid
attribute of users is missing.

To be able to find out that something is wrong, a debug message is now
logged when it has not been found.

Backport of 59f9107dd9497d2eb9bd61f5eb8d893dd8fcb766 from master
---

diff --git a/apps/user_ldap/group_ldap.php b/apps/user_ldap/group_ldap.php
index 0d3a70575ba..48d097c3600 100644
--- a/apps/user_ldap/group_ldap.php
+++ b/apps/user_ldap/group_ldap.php
@@ -283,6 +283,10 @@ class GROUP_LDAP extends BackendUtility implements \OCP\GroupInterface {
 			$uid = $userDN;
 		} else if(strtolower($this->access->connection->ldapGroupMemberAssocAttr) === 'memberuid') {
 			$result = $this->access->readAttribute($userDN, 'uid');
+			if ($result === false) {
+				\OCP\Util::writeLog('user_ldap', 'No uid attribute found for DN ' . $userDN . ' on '.
+					$this->access->connection->ldapHost, \OCP\Util::DEBUG);
+			}
 			$uid = $result[0];
 		} else {
 			// just in case