From: Michael Gapczynski <GapczynskiM@gmail.com>
Date: Tue, 15 May 2012 16:03:20 +0000 (-0400)
Subject: Create a new OC_Share object instead of manually inserting rows when adding a user... 
X-Git-Tag: v4.0.0RC2~44
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b619821f4a7048c56d198095c5c3b3c9fca02ae1;p=nextcloud-server.git

Create a new OC_Share object instead of manually inserting rows when adding a user to a group share, prevents a couple of potential bugs
---

diff --git a/apps/files_sharing/lib_share.php b/apps/files_sharing/lib_share.php
index 73ddaf0b9ea..9e43fef7696 100644
--- a/apps/files_sharing/lib_share.php
+++ b/apps/files_sharing/lib_share.php
@@ -472,12 +472,10 @@ class OC_Share {
 		$gid = '@'.$arguments['gid'];
 		$result = $query->execute(array($gid))->fetchAll();
 		if (count($result) > 0) {
-			$query = OCP\DB::prepare('INSERT INTO *PREFIX*sharing VALUES(?,?,?,?,?)');
-			$sharedFolder = '/'.$arguments['uid'].'/files/Shared/';
 			$lastSource = '';
 			for ($i = 0; $i < count($result) - 1; $i++) {
 				if ($result[$i]['source'] != $lastSource) {
-					$query->execute(array($result[$i]['uid_owner'], $arguments['uid'].'@'.$arguments['gid'], $result[$i]['source'], $sharedFolder.basename($result[$i]['source']), $result[$i]['permissions']));
+					new OC_Share($result[$i]['source'], $arguments['gid'], $result[$i]['permissions']);
 					$lastSource = $result[$i]['source'];
 				}
 			}