From: Thomas Citharel <tcit@tcit.fr>
Date: Thu, 4 Jun 2020 09:08:20 +0000 (+0200)
Subject: Fix empty event UUID reminder notifications
X-Git-Tag: v20.0.0beta1~460^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b61b74e81af2677aa9ad037ba17d02644891fd34;p=nextcloud-server.git

Fix empty event UUID reminder notifications

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---

diff --git a/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php b/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php
index c6b796b2acb..688e5c3b106 100644
--- a/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php
+++ b/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php
@@ -95,8 +95,10 @@ class PushProvider extends AbstractProvider {
 		$eventDetails = $this->extractEventDetails($vevent);
 		$eventDetails['calendar_displayname'] = $calendarDisplayName;
 		$eventUUID = (string) $vevent->UID;
-		// Empty Notification ObjectId will be catched by OC\Notification\Notification
-		$eventUUIDHash = $eventUUID ? hash('sha256', $eventUUID, false) : '';
+		if (!$eventUUID) {
+			return;
+		};
+		$eventUUIDHash = hash('sha256', $eventUUID, false);
 
 		foreach ($users as $user) {
 			/** @var INotification $notification */