From: Fabrice Bellingard <bellingard@gmail.com>
Date: Thu, 24 May 2012 13:44:09 +0000 (+0200)
Subject: SONAR-3348 Don't display links in filter if not browsable
X-Git-Tag: 3.1~77
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=bc4697565e2ac3bd35b95df2be7c00ed1458369e;p=sonarqube.git

SONAR-3348 Don't display links in filter if not browsable

=> The Links column on the filters page provides a Developer
   Connection link that browsers do not support
---

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_list.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_list.html.erb
index 27592eb2456..571b4188cbe 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_list.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_list.html.erb
@@ -155,7 +155,7 @@
         <% elsif column.on_date? %><%= human_short_date(snapshot.created_at) %>
         <% elsif column.on_key? %><span class="small"><%= snapshot.project.kee -%></span>
         <% elsif column.on_links?
-             @filter_context.links(snapshot.project_id).each do |link| %>
+             @filter_context.links(snapshot.project_id).select {|link| link.href.start_with?('http')}.each do |link| %>
           <%= link_to(image_tag(link.icon, :alt => link.name), link.href, :class => 'nolink', :popup => true) unless link.custom? %>
         <%   end
            end %>