From: Artur Signell <artur@vaadin.com>
Date: Wed, 30 Dec 2015 08:51:38 +0000 (+0200)
Subject: Always set header/footer style name to TH (#19209)
X-Git-Tag: 7.7.0.alpha1~126
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=bdec494f718d80cbd36363ce2e892647d31898d1;p=vaadin-framework.git

Always set header/footer style name to TH (#19209)

Change-Id: I8d0240fb76b9841e7290bf13588975da20c78b62
---

diff --git a/client/src/com/vaadin/client/widgets/Grid.java b/client/src/com/vaadin/client/widgets/Grid.java
index 806bc6a220..80b20fa184 100644
--- a/client/src/com/vaadin/client/widgets/Grid.java
+++ b/client/src/com/vaadin/client/widgets/Grid.java
@@ -5592,6 +5592,7 @@ public class Grid<T> extends ResizeComposite implements
 
                 Element td = cell.getElement();
                 td.removeAllChildren();
+                setCustomStyleName(td, metadata.getStyleName());
 
                 Element content;
                 // Wrap text or html content in default header to isolate
@@ -5622,7 +5623,6 @@ public class Grid<T> extends ResizeComposite implements
                 } else {
                     content = td;
                 }
-                setCustomStyleName(content, metadata.getStyleName());
 
                 switch (metadata.getType()) {
                 case TEXT:
diff --git a/uitest/src/com/vaadin/tests/components/grid/GridHeaderStyleNamesTest.java b/uitest/src/com/vaadin/tests/components/grid/GridHeaderStyleNamesTest.java
index f5216b4287..6dffe16a40 100644
--- a/uitest/src/com/vaadin/tests/components/grid/GridHeaderStyleNamesTest.java
+++ b/uitest/src/com/vaadin/tests/components/grid/GridHeaderStyleNamesTest.java
@@ -85,23 +85,23 @@ public class GridHeaderStyleNamesTest extends SingleBrowserTest {
         if (set) {
             assertHasStyleName(
                     "Footer cell should have the assigned 'age-footer' class name",
-                    getAgeFooterCellContent(), "age-footer");
+                    getAgeFooterCell(), "age-footer");
             assertHasStyleName(
                     "Header cell should have the assigned 'age' class name",
-                    getAgeHeaderCellContent(), "age");
+                    getAgeHeaderCell(), "age");
             assertHasStyleName(
                     "The merged header cell should have the assigned 'city-country' class name",
-                    getMergedHeaderCellContent(), "city-country");
+                    getMergedHeaderCell(), "city-country");
         } else {
             assertHasNotStyleName(
                     "Footer cell should not have the removed 'age-footer' class name",
-                    getAgeFooterCellContent(), "age-footer");
+                    getAgeFooterCell(), "age-footer");
             assertHasNotStyleName(
                     "Header cell should not have the removed 'age' class name",
-                    getAgeHeaderCellContent(), "age");
+                    getAgeHeaderCell(), "age");
             assertHasNotStyleName(
                     "Ther merged header cell should not have the removed 'city-country' class name",
-                    getMergedHeaderCellContent(), "city-country");
+                    getMergedHeaderCell(), "city-country");
         }
         assertHasStyleName(
                 "The default v-grid-cell style name should not be removed from the header cell",